Add zizmor pre-commit and fix reported issues#2381
Open
BarbUk wants to merge 2 commits intoBash-it:masterfrom
Open
Add zizmor pre-commit and fix reported issues#2381BarbUk wants to merge 2 commits intoBash-it:masterfrom
BarbUk wants to merge 2 commits intoBash-it:masterfrom
Conversation
seefood
reviewed
Apr 9, 2026
Contributor
seefood
left a comment
There was a problem hiding this comment.
I played with the idea, but I think it's an overkill to add this as a pre-commit dependency... this is maybe more of a post-commit action in the CI? what do you think?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
https://github.com/zizmorcore/zizmor is a static analysis tool for github action.
This PR add a precommit hook to check the CI workflow if modified.
Motivation and Context
Github workflow can be a security issue when not configured properly.
Zizmor will check for issues and report recommantion on how to fix those.
How Has This Been Tested?
❯ zizmor .github/ 🌈 zizmor v1.23.1 INFO audit: zizmor: 🌈 completed .github/workflows/ci.yml No findings to report. Good job! (9 suppressed)Types of changes
Checklist:
clean_files.txtand formatted it usinglint_clean_files.sh.