Add Continuous-Time Profile Likelihood Plots#193
Conversation
There was a problem hiding this comment.
Pull request overview
Adds the new continuous-time LTI profile likelihood deep-dive notebook to the documentation navigation, making it discoverable alongside the existing discrete-time notebook.
Changes:
- Added
deep_dives/continuous_time_lti_profile_likelihood.ipynbto the MkDocs nav under “Deep Dives”. - Added the same notebook link to
docs/tutorials.mdunder the Gallery list.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
mkdocs.yml |
Adds the continuous-time LTI profile likelihood notebook to the site navigation. |
docs/tutorials.md |
Adds a Gallery link to the new continuous-time notebook. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Nice! Some comments:
|
Whoops, changed that to see if it helped, but they're about the same. Changed back to the default.
This is blocked by #115. I tried to look at that, but it's a bit more complicated than it seems at first.
Also blocked by #115. |
|
This looks good to me now, thanks @mattlevine22! Unfortunately, still can't do UKF, since it results in a time-varying covariance, not allowed by our dynamax integration. |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - [Comparing Different MCMC Algorithms](deep_dives/mcmc_inference_algorithm_comparison.ipynb) | ||
| - [HUGE speedups if you assume perfect observations](deep_dives/l63_speedup_dirac_vs_enkf.ipynb) | ||
| - [SINDy (Sparse identification of non-linear dynamics)](deep_dives/fhn_sparse_id.ipynb) | ||
| - [Continuous-time LTI profile likelihood](deep_dives/continuous_time_lti_profile_likelihood.ipynb) |
There was a problem hiding this comment.
This link text says "Continuous-time" but the MkDocs nav entry uses "Continuous time". Please keep the title consistent across docs navigation and the tutorials/gallery page so users can easily recognize the same notebook.
| - [Continuous-time LTI profile likelihood](deep_dives/continuous_time_lti_profile_likelihood.ipynb) | |
| - [Continuous time LTI profile likelihood](deep_dives/continuous_time_lti_profile_likelihood.ipynb) |
There was a problem hiding this comment.
changed above to use dash
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This is analogous to the discrete-time notebook.