Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Changes how
tabsActiveis derived from editor selection and when it updates, which can affect tab activation behavior (especially with nested tabs) despite being editor-only logic.Overview
Refactors active-tab syncing so
tabsActiveis updated once perblockparty/tabsblock via a newuseSyncTabsActiveForTabsBlockhook, instead of renderingSyncTabsActiveinside every nav/panel item.The sync logic now infers the closest tab item from the current selection/ancestors, verifies ownership to avoid cross-updating nested tabs, and skips dispatches when
tabsActiveis already correct.Reviewed by Cursor Bugbot for commit 4ebd332. Bugbot is set up for automated code reviews on this repo. Configure here.