Skip to content

Fix cosmetic issues from PR #342 reviews#344

Merged
ddon merged 1 commit intoBeamLabEU:devfrom
timujinne:dev
Feb 16, 2026
Merged

Fix cosmetic issues from PR #342 reviews#344
ddon merged 1 commit intoBeamLabEU:devfrom
timujinne:dev

Conversation

@timujinne
Copy link
Contributor

Summary

  • Remove redundant <div class="mb-4"> wrapper around back buttons in 4 admin pages to match the ~40 other pages
  • Fix unless/else to if/else in permissions check for Credo compliance
  • Fix missed responsive text classes in storage, media selector and publishing pages

Changes

Back button consistency (4 files)

  • modules.html.heex, pages/pages.html.heex, maintenance/web/settings.html.heex, comments/web/settings.html.heex — back button is now a direct child of <header>, matching all other admin pages

Credo fix

  • permissions.ex — replace unless/else with if/else per Credo strict rules

Responsive text classes

  • Storage, media selector, publishing templates — add missing responsive sm:text-* classes

Test Plan

  • mix compile --warnings-as-errors passes
  • mix format clean
  • mix credo --strict passes
  • mix dialyzer passes
  • Visual check: back buttons render correctly without extra margin wrapper

Standardize back button markup to match the ~40 other admin pages
where the back link is a direct child of <header>, not wrapped in
an extra <div class="mb-4">.

Files: modules, pages, maintenance settings, comments settings.
@ddon ddon merged commit 2e0774a into BeamLabEU:dev Feb 16, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments