Fix cosmetic issues from PR #342 reviews#344
Merged
ddon merged 1 commit intoBeamLabEU:devfrom Feb 16, 2026
Merged
Conversation
Standardize back button markup to match the ~40 other admin pages where the back link is a direct child of <header>, not wrapped in an extra <div class="mb-4">. Files: modules, pages, maintenance settings, comments settings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<div class="mb-4">wrapper around back buttons in 4 admin pages to match the ~40 other pagesunless/elsetoif/elsein permissions check for Credo complianceChanges
Back button consistency (4 files)
modules.html.heex,pages/pages.html.heex,maintenance/web/settings.html.heex,comments/web/settings.html.heex— back button is now a direct child of<header>, matching all other admin pagesCredo fix
permissions.ex— replaceunless/elsewithif/elseper Credo strict rulesResponsive text classes
sm:text-*classesTest Plan
mix compile --warnings-as-errorspassesmix formatcleanmix credo --strictpassesmix dialyzerpasses