Closes #5272: alignment tests for arkouda.numpy.pdarraysetops#5274
Draft
ajpotts wants to merge 1 commit intoBears-R-Us:mainfrom
Draft
Closes #5272: alignment tests for arkouda.numpy.pdarraysetops#5274ajpotts wants to merge 1 commit intoBears-R-Us:mainfrom
ajpotts wants to merge 1 commit intoBears-R-Us:mainfrom
Conversation
68918e2 to
26838e5
Compare
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5274 +/- ##
========================================
Coverage ? 100.00%
========================================
Files ? 45
Lines ? 1424
Branches ? 0
========================================
Hits ? 1424
Misses ? 0
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
26838e5 to
3d0ef27
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add NumPy alignment test suite for pdarray set operations
Summary
This PR adds a comprehensive NumPy-alignment test suite for Arkouda pdarray set operations, covering:
in1dunion1dintersect1dsetdiff1dsetxor1dconcatenateindexof1dThe goal is to explicitly verify semantic alignment with NumPy behavior and to surface existing deviations in a controlled, well-documented way.
What’s included
tests/numpy/alignment_verification/pdarraysetops_alignment.pypytest.iniso the suite runs as part of standard alignment verification.assume_unique=Truecases:Known issues (documented via xfail)
ak.union1ddoes not match NumPy semantics when one input is empty.xfailand linked to Issue Bug:ak.union1dnot NumPy-aligned for empty-input cases (returns non-unique / unsorted) #5273, so the suite remains informative but non-blocking.Why this matters
assume_unique) from real semantic gaps in Arkouda.Follow-up work
ak.union1dempty-input fast paths to applyunique + sort.xfails once behavior matches NumPy.Testing
xfails.Closes #5272: alignment tests for arkouda.numpy.pdarraysetops