Closes #5287: alignment tests for arkouda.numpy.strings#5291
Open
ajpotts wants to merge 1 commit intoBears-R-Us:mainfrom
Open
Closes #5287: alignment tests for arkouda.numpy.strings#5291ajpotts wants to merge 1 commit intoBears-R-Us:mainfrom
ajpotts wants to merge 1 commit intoBears-R-Us:mainfrom
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5291 +/- ##
========================================
Coverage ? 100.00%
========================================
Files ? 45
Lines ? 1301
Branches ? 0
========================================
Hits ? 1301
Misses ? 0
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
drculhane
approved these changes
Jan 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add NumPy alignment tests for Arkouda Strings
Summary
This PR introduces a comprehensive NumPy-alignment test suite for
ak.Stringsand wires it into the existing NumPy test runs. The goal is to explicitly
document, enforce, and track parity (and known divergence) between Arkouda
Strings and NumPy/Python string semantics.
What’s included
tests/numpy/alignment_verification/strings_alignment.pypytest.iniso it runs with the rest of the NumPy alignment suitelower,upper,title,capitalize)isdigit,isalpha,isalnum, etc.)==,!=, scalar comparisons)contains)Handling known divergences
Several behaviors currently differ from NumPy/Python semantics. These are
intentionally captured using
xfail(strict=True)so that:Tracked divergences:
\u03C3Strings.istitle()semanticsTruefor digit-only and whitespace-only stringsStrings.isnumeric()semanticsTruefor the empty stringWhy this matters
pdarrayReviewer notes
xfail(strict=True)is used deliberately to ensure future fixes are detectedRUF001)re.error/PatternError(Python 3.13+ behavior)Closes #5287: alignment tests for arkouda.numpy.strings