Closes #5336: ArkoudaExtensionArray.value_counts#5338
Open
ajpotts wants to merge 3 commits intoBears-R-Us:mainfrom
Open
Closes #5336: ArkoudaExtensionArray.value_counts#5338ajpotts wants to merge 3 commits intoBears-R-Us:mainfrom
ajpotts wants to merge 3 commits intoBears-R-Us:mainfrom
Conversation
b7756ec to
7d58aa8
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5338 +/- ##
========================================
Coverage ? 100.00%
========================================
Files ? 5
Lines ? 115
Branches ? 0
========================================
Hits ? 115
Misses ? 0
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
3945138 to
c490734
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds
value_countsimplementations for Arkouda-backed pandas ExtensionArrays, including:ArkoudaArrayArkoudaStringArrayArkoudaCategoricalArrayThe goal is to provide pandas-compatible behavior for counting unique values while leveraging Arkouda’s server-side aggregation.
Motivation
value_countsis a core pandas API that users expect to work on ExtensionArrays. Prior to this change:value_countswas not implemented (or explicitly disabled) for Arkouda-backed arraysThis PR enables efficient server-side counting and returns a pandas
Serieswith Arkouda-backed index and values where appropriate.What’s included
ArkoudaArray
value_counts(dropna=True)dropna=Trueforfloat64by filteringNaNvaluesSeriesfor empty inputsort,normalize,bins)ArkoudaStringArray
value_counts(dropna=True)GroupBy.size()onStringsdropnafor pandas compatibility (currently inert)ArkoudaCategoricalArray
value_counts(dropna=True|False)na_valuewhendropna=TrueTests
dropnabehaviorNon-goals / future work
sort,ascending,normalize, andbinsare not yet implementedCloses #5336: ArkoudaExtensionArray.value_counts