Aligns zeros and ones to numpy, adds and/or fixes overloads to zeros, ones, full#5376
Open
drculhane wants to merge 9 commits intoBears-R-Us:mainfrom
Open
Aligns zeros and ones to numpy, adds and/or fixes overloads to zeros, ones, full#5376drculhane wants to merge 9 commits intoBears-R-Us:mainfrom
drculhane wants to merge 9 commits intoBears-R-Us:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5376 +/- ##
========================================
Coverage ? 100.00%
========================================
Files ? 5
Lines ? 115
Branches ? 0
========================================
Hits ? 115
Misses ? 0
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5375
As noted in Issue 5375, we weren't handling dtype=None correctly in zeros and ones. This fixes that.
It also adds overloads to zeros and ones, and corrects/updates the overloads for full. The full overloads are much trickier, since dtype=None causes different behavior than it does in zeros and ones (it infers the dtype from the fill_value).
There is also a change in util.py in a line where full is called. The type is resolved to something compatible with the new overloads.