Aligns round function to numpy, adds unit tests#5396
Open
drculhane wants to merge 3 commits intoBears-R-Us:mainfrom
Open
Aligns round function to numpy, adds unit tests#5396drculhane wants to merge 3 commits intoBears-R-Us:mainfrom
drculhane wants to merge 3 commits intoBears-R-Us:mainfrom
Conversation
drculhane
force-pushed
the
Closes-5386
branch
from
5b0b7fc to
5e06ac6
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5396 +/- ##
========================================
Coverage ? 100.00%
========================================
Files ? 5
Lines ? 115
Branches ? 0
========================================
Hits ? 115
Misses ? 0
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ajpotts
reviewed
Feb 4, 2026
ajpotts
approved these changes
Feb 4, 2026
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
drculhane
force-pushed
the
Closes-5386
branch
from
e6c98a0 to
cc167b0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5386
This aligns round to numpy by:
(1) removing the "where" parameter (numpy round doesn't have this),
(2) adding a "decimals" parameter to allow for rounding to a number of decimal places,
(3) implementing numpy's "round to even" (e.g. 2.5 rounds to 2, but 3.5 rounds to 4).
It also adds unit tests for round. There hadn't been any.