Implement DerivedTypeMeta to store meta information for derived types#235
Merged
Bergmann89 merged 1 commit intomasterfrom Feb 7, 2026
Merged
Implement DerivedTypeMeta to store meta information for derived types#235Bergmann89 merged 1 commit intomasterfrom
DerivedTypeMeta to store meta information for derived types#235Bergmann89 merged 1 commit intomasterfrom
Conversation
Bergmann89
force-pushed
the
issue-234
branch
2 times, most recently
from
9657b4b to
e5a8875
Compare
Like `GroupMeta`, `DynamicMeta` may hold derived types with the same name (from different schemas), but in difference to `GroupMeta`, it does not provide meta information like the `display_name`, so we can not resolve potential naming conflicts as we do it for elements in `GroupMeta`. This commit implements `DerivedTypeMeta` which is stored in `DynamicMeta` to keep track of the derived types and its meta information. It also resolves the issue with the naming conflicts for derived types by using setting a suitable `display_name` for conflicting names.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Like
GroupMeta,DynamicMetamay hold derived types with the same name (from different schemas), but in difference toGroupMeta, it does not provide meta information like thedisplay_name, so we can not resolve potential naming conflicts as we do it for elements inGroupMeta. This commit implementsDerivedTypeMetawhich is stored inDynamicMetato keep track of the derived types and it's meta information. It also resolves the issue with the naming conflicts for derived types by using setting a suitabledisplay_namefor conflicting names.Related to #234