Skip to content

Comments

Remove requirements.txt and use pyproject.toml dependencies#451

Merged
ducky64 merged 3 commits intomasterfrom
cleaning
Feb 23, 2026
Merged

Remove requirements.txt and use pyproject.toml dependencies#451
ducky64 merged 3 commits intomasterfrom
cleaning

Conversation

@ducky64
Copy link
Collaborator

@ducky64 ducky64 commented Feb 23, 2026

No description provided.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Migrates Python dependency management from requirements.txt to pyproject.toml, and updates CI/docs to install the package (and dev extras) via pip from the project metadata.

Changes:

  • Remove requirements.txt and rely on [project.dependencies] / [project.optional-dependencies] in pyproject.toml.
  • Update GitHub Actions workflows to pip install -e . / pip install -e .[dev] instead of pip install -r requirements.txt.
  • Add a brief “building from source” install note to the README.

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
requirements.txt Removed legacy dependency list in favor of pyproject.toml.
pyproject.toml Adds pydantic to core deps; moves typing stubs into dev extra.
README.md Documents source install command.
.github/workflows/pr-scala.yml CI now installs the Python package from the repo root.
.github/workflows/pr-python.yml CI now installs package/dev extra instead of requirements.txt.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

pyproject.toml Outdated
Comment on lines 31 to 35
"typing_extensions",
"types-Deprecated==1.2.9.20240311",
"types-protobuf"
]

Copy link

Copilot AI Feb 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typing_extensions is already a core dependency (typing_extensions >= 4.4.0), so listing it again in the dev extra is redundant. Removing the duplicate entry will reduce confusion and keep dependency definitions single-sourced.

Suggested change
"typing_extensions",
"types-Deprecated==1.2.9.20240311",
"types-protobuf"
]
"types-Deprecated==1.2.9.20240311",
"types-protobuf"
]

Copilot uses AI. Check for mistakes.
run: |
pip install -r requirements.txt
pip install -e .[dev]
pip install black
Copy link

Copilot AI Feb 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The workflow installs .[dev] (which already includes black) and then installs black again. This is redundant and can introduce nondeterminism if the extra and the subsequent install resolve to different versions; prefer installing black in one place (either via the dev extra, or remove it from the extra and install it explicitly here).

Suggested change
pip install black

Copilot uses AI. Check for mistakes.
README.md Outdated

**Setup tl;dr**: install the Python package from pip: `pip install edg`, and optionally run the [IDE plugin with block diagram visualizer](setup.md#ide-setup).

Building from source: `pip install .` at the repository root.
Copy link

Copilot AI Feb 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There’s an extra space after the colon and trailing whitespace at the end of this line. Cleaning this up avoids markdown lint noise and keeps formatting consistent.

Suggested change
Building from source: `pip install .` at the repository root.
Building from source: `pip install .` at the repository root.

Copilot uses AI. Check for mistakes.
pyproject.toml Outdated
@@ -21,12 +21,16 @@ dependencies = [
"sexpdata==0.0.3",
"Deprecated",
Copy link

Copilot AI Feb 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since requirements.txt is being removed, the effective constraint for Deprecated becomes unpinned ("Deprecated"). Previously it was pinned to 1.2.14 in requirements.txt; consider pinning it here as well to avoid accidental upgrades breaking runtime behavior/CI reproducibility.

Suggested change
"Deprecated",
"Deprecated==1.2.14",

Copilot uses AI. Check for mistakes.
@ducky64 ducky64 merged commit a7e274c into master Feb 23, 2026
12 checks passed
@ducky64 ducky64 deleted the cleaning branch February 23, 2026 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant