Remove release plugin arguments from pom.xml and update workflows#355
Merged
thomasturrell merged 5 commits intomainfrom Nov 17, 2025
Merged
Remove release plugin arguments from pom.xml and update workflows#355thomasturrell merged 5 commits intomainfrom
thomasturrell merged 5 commits intomainfrom
Conversation
Co-authored-by: thomasturrell <1552612+thomasturrell@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Remove release plugin arguments from pom.xml and update workflows
Remove release plugin arguments from pom.xml and update workflows
Nov 17, 2025
Co-authored-by: thomasturrell <1552612+thomasturrell@users.noreply.github.com>
Contributor
|
@copilot did you see my new comment |
Co-authored-by: thomasturrell <1552612+thomasturrell@users.noreply.github.com>
Contributor
Author
Contributor
|
@copilot do i need the --file pom.xml parameter and value |
Contributor
Author
No, However, it's currently used consistently in other workflows ( For consistency with |
thomasturrell
approved these changes
Nov 17, 2025
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
The maven-release-plugin fails when
-plarguments are passed via<arguments>configuration in pom.xml:Resolves https://github.com/BerryCloud/xapi-java/actions/runs/19414252617
Changes
pom.xml
<arguments>configuration from maven-release-pluginWorkflows
-pland-amflags directly in all Maven commands with consistent syntax across both workflowsmaven-publish.yml: Place-pland-amflags directly before therelease:prepare release:performgoalsrelease.yml: Place-pland-amflags directly before bothrelease:prepareandrelease:performgoalsExample from
maven-publish.yml:mvn -B -pl xapi-model,xapi-client,xapi-model-spring-boot-starter -am -batch-mode release:prepare release:perform --file pom.xmlExample from
release.yml(release:prepare):Example from
release.yml(release:perform):Both workflow files now use the same consistent syntax with
-pland-amflags placed directly in the Maven command (not wrapped in-Darguments), ensuring only production modules (xapi-model, xapi-client, xapi-model-spring-boot-starter) are released while excluding all sample modules.Checklist:
Public methods are documented
Public methods are tested
New and existing tests pass when run locally
There are no new warnings or errors
Fixes [Chore]: Remove release plugin arguments from pom.xml and update workflows #354
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.