Improve Javadoc coverage and suppress Lombok-generated warnings#389
Merged
thomasturrell merged 11 commits intomainfrom Nov 19, 2025
Merged
Improve Javadoc coverage and suppress Lombok-generated warnings#389thomasturrell merged 11 commits intomainfrom
thomasturrell merged 11 commits intomainfrom
Conversation
…d fix remaining javadoc issues Co-authored-by: thomasturrell <1552612+thomasturrell@users.noreply.github.com>
Co-authored-by: thomasturrell <1552612+thomasturrell@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Improve Javadoc coverage and documentation accuracy
Improve Javadoc coverage and suppress Lombok-generated warnings
Nov 18, 2025
thomasturrell
requested changes
Nov 19, 2025
Co-authored-by: thomasturrell <1552612+thomasturrell@users.noreply.github.com>
Co-authored-by: thomasturrell <1552612+thomasturrell@users.noreply.github.com>
thomasturrell
approved these changes
Nov 19, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR successfully improves JavaDoc coverage across the xAPI Java library by adding missing documentation to public APIs and configuring Maven to suppress unavoidable Lombok-generated warnings. The changes reduce javadoc warnings from 299 to 0 while enhancing developer documentation.
- Added
@returntags to validation constraint annotations and Spring autoconfiguration bean methods - Added
@paramtags to constructors, deserializers, and public client methods - Fixed incorrect
@inheritDocusage inXapiTimestamp.parse() - Configured Maven javadoc plugin to suppress missing documentation warnings
- Enhanced
CONTRIBUTING.mdwith comprehensive JavaDoc guidelines and examples
Reviewed Changes
Copilot reviewed 20 out of 20 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| pom.xml | Configured javadoc plugin with -Xdoclint:all,-missing to suppress Lombok-generated warnings |
| ValidActivityDefinition.java | Added @return tags for message(), groups(), and payload() methods |
| VaildScore.java | Added @return tags for constraint annotation methods |
| Statements.java | Added @return tags for constraint annotation methods |
| ScaledScore.java | Added @return tags for constraint annotation methods |
| NotUndetermined.java | Added @return tags for constraint annotation methods |
| Mbox.java | Added @return tags for constraint annotation methods |
| HasScheme.java | Added @return tags for constraint annotation methods |
| XapiTimestamp.java | Fixed incorrect @inheritDoc usage and added proper method documentation |
| StrictTimestampDeserializer.java | Added constructor documentation with @param tags |
| StrictObjectTypeResolverBuilder.java | Added constructor documentation for nested deserializer class |
| StrictLocaleDeserializer.java | Added default constructor documentation |
| XapiModelAutoConfiguration.java | Added @return tags to all 17 Spring bean factory methods |
| XapiClient.java | Added @param tags to 8 public methods |
| XapiServerApplication.java | Added main method documentation with @param tag |
| StatementService.java | Added constructor documentation with @param tags |
| StatementEntity.java | Added constructor documentation with @param tags |
| StatementController.java | Added constructor and method parameter documentation |
| ServerControllerAdvice.java | Added exception handler method documentation with @param tags |
| CONTRIBUTING.md | Enhanced with comprehensive JavaDoc guidelines, examples, and best practices |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…sing Co-authored-by: thomasturrell <1552612+thomasturrell@users.noreply.github.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Resolves #388
Running
mvn javadoc:javadocproduced 299 warnings. The majority (134) stemmed from Lombok-generated builders with default constructors that cannot be manually documented. The remainder were missing@paramand@returntags on public APIs.Changes
Maven Configuration
<doclint>all,-missing</doclint>to suppress unavoidable Lombok-generated warnings while preserving all other quality checks-missingflag specifically suppresses missing documentation warnings (primarily Lombok-generated code)Documentation Fixes (19 files)
@returntags to validation constraint annotations (7 files:message(),groups(),payload()methods)@returntags to Spring autoconfiguration bean methods (17 methods inXapiModelAutoConfiguration)@paramtags to sample server classes (5 files)@paramtags toXapiClientpublic methods (8 methods)@inheritDocinXapiTimestamp.parse()Project Documentation (1 file)
CONTRIBUTING.mdwith detailed JavaDoc guidelines, code examples, and note about Lombok-generated code suppressionResult: 299 → 0 javadoc warnings
Technical Notes
The initial suggestion to use
<excludeAnnotations>lombok.Generated</excludeAnnotations>was attempted but this parameter is not supported by maven-javadoc-plugin 3.11.3. The final solution uses<doclint>all,-missing</doclint>which effectively suppresses Lombok-generated warnings without causing Maven parameter warnings.Checklist:
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.