Address PR review feedback: fix repository interface, documentation, and validation#406
Merged
thomasturrell merged 3 commits intocodex/implement-get-statements-since-datefrom Nov 22, 2025
Conversation
…prove validation Co-authored-by: thomasturrell <1552612+thomasturrell@users.noreply.github.com>
Co-authored-by: thomasturrell <1552612+thomasturrell@users.noreply.github.com>
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] Add stored timestamp column for statement retrieval
Address PR review feedback: fix repository interface, documentation, and validation
Nov 21, 2025
thomasturrell
approved these changes
Nov 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Addresses all review comments from PR #404. The build was failing due to missing CRUD operations in
StatementRepository, and several documentation and code quality issues were identified.Resolves #404 (review feedback)
Changes
Repository Interface
StatementRepositorywith bothPagingAndSortingRepositoryandCrudRepositoryto restorefindById(),save(), andsaveAll()methodsStatementEntity
storedcolumn non-nullable to prevent ordering inconsistenciesStatementService
PageRequest.of()(already defined in repository method names)Instant.now()outside batch processing loop to ensure consistent timestamps within a batchChecklist:
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.