Fix Lombok annotation processing failure in xapi-model-spring-boot-starter#456
Conversation
…model-spring-boot-starter Co-authored-by: thomasturrell <1552612+thomasturrell@users.noreply.github.com>
|
@copilot use generic class names like Person |
Co-authored-by: thomasturrell <1552612+thomasturrell@users.noreply.github.com>
|
There was a problem hiding this comment.
Pull request overview
This PR fixes a Lombok annotation processing failure that occurred when third-party projects depended on xapi-model-spring-boot-starter. The starter module previously excluded spring-boot-starter-jackson for jjwt compatibility but didn't configure Lombok, causing compilation failures in consuming projects that used Lombok annotations.
Key Changes:
- Added Lombok dependency and compiler configuration to enable annotation processing
- Included lombok.config file to standardize Lombok behavior
- Added comprehensive tests to verify Lombok annotations work correctly
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| xapi-model-spring-boot-starter/pom.xml | Added Lombok as a dependency with maven-compiler-plugin configuration for annotation processing, and spring-boot-starter-test for testing |
| xapi-model-spring-boot-starter/lombok.config | Added Lombok configuration to suppress code coverage and standardize builder/constructor behavior |
| xapi-model-spring-boot-starter/src/test/java/.../LombokProcessingTests.java | Added tests verifying @Getter, @Setter, @builder, and @value annotations process correctly |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
Co-authored-by: thomasturrell <1552612+thomasturrell@users.noreply.github.com>
|
This turned out to be a false positive |



Description
Lombok annotation processing fails for third-party classes when depending on xapi-model-spring-boot-starter. The starter excludes
spring-boot-starter-jacksonin favor ofspring-boot-jackson2for jjwt compatibility, but does not configure Lombok, causing compilation failures in consuming projects.Changes
xapi-model-spring-boot-starter/pom.xml
lombokas optional dependency to make it available transitivelymaven-compiler-pluginwith Lombok annotation processor pathspring-boot-starter-testdependency for testingxapi-model-spring-boot-starter/lombok.config
xapi-modelandxapi-clientmodulesxapi-model-spring-boot-starter/src/test/java/.../LombokProcessingTests.java
@Getter,@Setter,@Builder, and@Valueannotations process correctlyImpact
Projects depending on xapi-model-spring-boot-starter can now use Lombok annotations without additional configuration:
Checklist:
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.