write test for 'last' magic string of next() function#1
Open
bpernick wants to merge 1 commit intoBigFax:masterfrom
Open
write test for 'last' magic string of next() function#1bpernick wants to merge 1 commit intoBigFax:masterfrom
bpernick wants to merge 1 commit intoBigFax:masterfrom
Conversation
Author
|
Are you still working on this PR? And if so, what (if any) further coverage might you need? |
Owner
|
Hey, I did not really investigate more the PR. Personally, I no longer use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey there! Just curious where you're at with this ticket. Noticed you've had a pr open for a while in need of tests; I've written a relatively naive test that basically just proves that the "last" magic string does in fact jump to the last middleware.