Fix building on NetBSD#423
Open
Kaleb-Reid wants to merge 1 commit intoBinomialLLC:masterfrom
Open
Conversation
akien-mga
approved these changes
Apr 27, 2026
Contributor
akien-mga
left a comment
akien-mga
left a comment
There was a problem hiding this comment.
Changes seem correct to me.
We'll be making this change downstream in Godot so I'd support it being integrated upstream too, so we don't keep this as a patch forever (but we can of course if this change is not warranted upstream).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on godotengine/godot#114233 I found that this prevented building on NetBSD 10.1. I don't remember as to why this is the case but the Godot CI builds on all other supported platforms were successful and there are already instances of
std::isinfandstd::isnanin the codebase so this just makes them all use the std namespace.