Conversation
According to https://github.com/root-project/root/blob/fb17cef3cb381772f7d930c213801b82b65fef52/core/dictgen/src/rootcling_impl.cxx#L5572 and genreflex -debug, the -f is needed
This file contains a updated version of ROOT_GENERATED_DICTIONARY that can generate C++ Modules
BioDynaMo's already uses .cc extension for the dictionary files, so I don't want to change that
Also removes the old ROOT_GENERATE_DICTIONARY and REFLEX_GENERATE_DICTIONARY functions from FindROOT.cmake
imorlxs
force-pushed
the
cppmodules
branch
2 times, most recently
from
8fb2c21 to
5de61fe
Compare
See deprecation warning documented in #386.
…n't need to pass the headers to the interpreter anymore.
|
| set(NO_MODULE "NO_CXXMODULE") | ||
| endif() | ||
|
|
||
| if (NOT ${TARGET} STREQUAL "biodynamo") |
There was a problem hiding this comment.
This if can be removed as is not longer necessary
| add_custom_command(TARGET ${TARGET} | ||
| POST_BUILD | ||
| COMMAND ${CMAKE_COMMAND} -E copy ${DICT_FILE}_rdict.pcm ${CMAKE_INSTALL_LIBDIR}) | ||
| # add_custom_command(TARGET ${TARGET} |
There was a problem hiding this comment.
Also, this code is not longer necessary, as ROOT_GENERATE_DICTIONARY already generates the .pcm in CMAKE_INSTALL_LIBDIR
| set(LAUNCHER ${CMAKE_BINARY_DIR}/launcher.sh) | ||
| endif() | ||
|
|
||
| #---------------------------------------------------------------------------- |
There was a problem hiding this comment.
This function is now in RootMacros.cmake, imported from the root source code.
|
Could you review the code? @LukasBreitwieser @FonsRademakers @TobiasDuswald Feel free to request as many changes as needed. I want to know how I'm doing, and try to improve my code. P.D.: Also, if I need to clean the commit history, or any another change, please tell me :) |
imorlxs
requested review from
FonsRademakers,
LukasBreitwieser and
TobiasDuswald
3 participants
This PR enables C++ Modules in BioDynaMo.
IMPORTANT: Notebooks don't work with this PR
Please don't merge it for now