forked from hms-dbmi/vizarr
-
Notifications
You must be signed in to change notification settings - Fork 4
feat/roi-selector-plugin #62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
AlexSurtees
merged 33 commits into
BioNGFF:dev
from
LucaAnce:luca-anceschi/feat/roi-selector-plugin
May 29, 2026
Merged
Changes from all commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
84f9cf1
feat!: roi selection plugin
LucaAnce 65a9ade
feat!: implemented multiple ROI selection and handling. UI cleaned an…
LucaAnce a8df79b
refactor: make roi-selector an optional plugin from pnpm
LucaAnce 919f350
refactor: moved roi-specific logic and atoms to roi folder
LucaAnce fce69f7
feat: bounds ROI (x,y,z) to image sizes
LucaAnce 4f12409
refactor: divided roi selector into components for ease of maintenance
LucaAnce 4048192
fix: correct go to roi bugs
LucaAnce ebbb9f1
refactor: pnpm fix before PR
LucaAnce 9b3cd95
refactor+fix: minor refactors/fixes from automatic AI PR review
LucaAnce 5d5abf2
refactor: replace runtime fallback with compile-time toggle
LucaAnce daf9d00
refactor(roi-selector): consolidate coordinate fields, reduce verbosi…
LucaAnce f4ab86a
refactor: revert conditional roi-selector plugin logic
LucaAnce 5122b46
refactor: consolidated corner data structure (vs previous x1,y1, ...)…
LucaAnce 9c17dbd
fix: solve bug of UI manual coord edit field able to save out of boun…
LucaAnce e8bca7a
feat: support roi names
LucaAnce e40b2ea
refactor: replace shared atoms with ViewerPluginContext for plugin-vi…
LucaAnce 9116754
refactor: solve t/zMax info redundancy in API
LucaAnce 0e769be
chore: remove redundant roi-selector.d.ts
LucaAnce 9953b2b
fix: single roi exported as 1-item list to match fractal task require…
LucaAnce b793476
feat: delete all button. confirmation dialog before delete 1 or more …
LucaAnce 504c7fd
fix: change rel path and dev constraint for fractal integration
LucaAnce ec87ac0
refactor: remove square bracket around exported single ROI for better…
LucaAnce 59541ef
refactor!: lift viewer plugin context to app level. app as viewer/plu…
LucaAnce 6febf7d
fix: make saved ROIs list scrollable and bounded to viewport size
LucaAnce 370dd5e
refactor: uniform use of physical world coordinates everywhere
LucaAnce a2c97a2
feat!: import ROIs from tables in the zarr
LucaAnce 472c26a
feat: add tooltip for import roi btn
LucaAnce a18ac12
fix: load imported roi names correctly
LucaAnce 20c45c0
fix: removed unnecessary conversion in inport time
LucaAnce 6a64637
refactor: now exclude non-roi tables, masking roi non selected by def…
LucaAnce 1d861c0
Merge branch 'dev' into luca-anceschi/feat/roi-selector-plugin
AlexSurtees 378e670
fix: correct for lint and check to pass
LucaAnce 9e678bf
fix: build plugin before check
LucaAnce File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,5 @@ | ||
| packages: | ||
| - 'viewer' | ||
| - 'roi-selector' | ||
| - 'sites/*' | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| { | ||
| "name": "@biongff/roi-selector", | ||
| "private": true, | ||
| "version": "0.0.0", | ||
| "type": "module", | ||
| "main": "dist/biongff-roi-selector.cjs.js", | ||
| "module": "dist/biongff-roi-selector.es.js", | ||
| "types": "dist/index.d.ts", | ||
| "files": ["dist"], | ||
| "exports": { | ||
| ".": { | ||
| "types": "./dist/index.d.ts", | ||
| "import": "./dist/biongff-roi-selector.es.js", | ||
| "require": "./dist/biongff-roi-selector.cjs.js" | ||
| } | ||
| }, | ||
| "scripts": { | ||
| "dev": "vite", | ||
| "build": "npm run check && vite build", | ||
| "preview": "vite preview", | ||
| "check": "tsc" | ||
| }, | ||
| "dependencies": { | ||
| "@biongff/vizarr": "workspace:*", | ||
| "zarrita": "0.5.0" | ||
| }, | ||
| "peerDependencies": { | ||
| "@emotion/react": "^11.14.0", | ||
| "@emotion/styled": "^11.14.1", | ||
| "@mui/icons-material": "^7.2.0", | ||
| "@mui/material": "^7.2.0", | ||
| "deck.gl": "~9.0.0", | ||
| "react": "^18.2.0", | ||
| "react-dom": "^18.2.0" | ||
| }, | ||
| "devDependencies": { | ||
| "@types/react": "^18.3.10", | ||
| "@types/react-dom": "^18.2.18", | ||
| "@vitejs/plugin-react": "^4.3.4", | ||
| "typescript": "^5.8.2", | ||
| "vite": "^6.2.7", | ||
| "vite-plugin-dts": "^4.5.4" | ||
| } | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.