chore(exports): add __version__ to __all__ for complete public API#9
Merged
Conversation
__version__ = '2.1.0' was defined at module level but omitted from __all__, meaning `from bsp_sdk import *` would not expose it and tools like `bsp_sdk.__version__` checks via __all__ introspection would miss it. Add it as the first entry under a 'Package metadata' comment. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
__version__ = '2.1.0'was defined at module level but not listed in__all__from bsp_sdk import *silently omits the version, and introspection tools that enumerate__all__miss it"__version__"as the first entry under a# Package metadatacommentWhy this matters
Tools like
importlib.metadata, version checkers, and wildcard imports rely on__all__being the authoritative list of public symbols. Omitting__version__is a small but real inconsistency.Test plan
python -c "from bsp_sdk import *; print(__version__)"→ prints2.1.0python -c "import bsp_sdk; assert '__version__' in bsp_sdk.__all__"python -c "import bsp_sdk; print(bsp_sdk.__version__)"→2.1.0(unchanged)🤖 Generated with Claude Code