Skip to content

Rithin/an 1208 dotnet coverage#26

Draft
L0Lmaker wants to merge 7 commits into3.5-devfrom
rithin/an-1208-dotnet-coverage
Draft

Rithin/an 1208 dotnet coverage#26
L0Lmaker wants to merge 7 commits into3.5-devfrom
rithin/an-1208-dotnet-coverage

Conversation

@L0Lmaker
Copy link
Copy Markdown

No description provided.

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 26, 2022

Codecov Report

Merging #26 (33ad43f) into 3.5-dev (c6578fa) will increase coverage by 18.99%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           3.5-dev      #26       +/-   ##
============================================
+ Coverage    63.58%   82.58%   +18.99%     
============================================
  Files           23      196      +173     
  Lines         3636     5500     +1864     
  Branches         0      499      +499     
============================================
+ Hits          2312     4542     +2230     
+ Misses        1145      832      -313     
+ Partials       179      126       -53     
Impacted Files Coverage Δ
gremlin-go/driver/result.go
gremlin-go/driver/driverRemoteConnection.go
gremlin-go/driver/transporterFactory.go
gremlin-go/driver/connectionPool.go
gremlin-go/driver/logger.go
gremlin-go/driver/bytecode.go
gremlin-go/driver/anonymousTraversal.go
gremlin-go/driver/strategies.go
gremlin-go/driver/graphTraversalSource.go
gremlin-go/driver/serializer.go
... and 209 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Cole-Greer pushed a commit that referenced this pull request Mar 26, 2026
…-8s2)

antlr4ng was pinned with a tilde (~3.0.16) and the patch script ran via
postinstall, meaning it executed for all downstream npm consumers even
though they don't need it — the patch is purely a build-time stop-gap for
missing .d.cts CJS type declarations in antlr4ng (upstream issues #23/#26).

- Pin antlr4ng to exact version 3.0.16 to prevent silent breakage on upgrades
- Move patch invocation from postinstall to prebuild so consumers are never affected
- Add workspace hoisting fallback (checks parent node_modules if local not found)
- Fail loudly with actionable error if antlr4ng dist layout has changed
- Warn (non-fatal) if antlr4ng package is not found at all
- Add _prebuild_note in package.json explaining the stop-gap and upgrade guidance
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant