Skip to content

fix: sanitize wallet object from logs #7929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Marzooqa merged 1 commit into from
Jan 19, 2026
+16 −2
Merged

fix: sanitize wallet object from logs #7929

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions modules/sdk-core/src/bitgo/wallet/wallet.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2407,7 +2407,15 @@ export class Wallet implements IWallet {
'transaction params:',
_.omit(params, ['keychain', 'prv', 'passphrase', 'walletPassphrase', 'key', 'wallet'])
);
console.error('transaction prebuild:', txPrebuild);
// Sanitize to remove _token from bitgo
const sanitizedPrebuild = {
..._.omit(txPrebuild, ['wallet']),
wallet: {
...this,
bitgo: _.omit(this.bitgo, ['_token']),
},
};
console.error('transaction prebuild:', sanitizedPrebuild);
console.trace(e);
throw e;
}
Expand Down Expand Up @@ -2449,7 +2457,13 @@ export class Wallet implements IWallet {
confirmedBalance: this.confirmedBalance(),
spendableBalance: this.spendableBalance(),
};
error.txParams = _.omit(params, ['keychain', 'prv', 'passphrase', 'walletPassphrase', 'key']);
error.txParams = {
..._.omit(params, ['keychain', 'prv', 'passphrase', 'walletPassphrase', 'key', 'wallet']),
wallet: {
...this,
bitgo: _.omit(this.bitgo, ['_token']),
},
};
}
throw error;
}
Expand Down
Loading