Skip to content

feat(sdk-core, abstract-utxo): enhance explainTransaction with wallet context #7932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
OttoAllmendinger wants to merge 2 commits into
base: master
Choose a base branch
from
+15 −4
Open

feat(sdk-core, abstract-utxo): enhance explainTransaction with wallet context #7932

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
70b4e34
feat(sdk-core): pass wallet to explainTransaction
OttoAllmendinger Jan 19, 2026
3ca122b
feat(abstract-utxo): fetch keychains from wallet in explainTransaction
OttoAllmendinger Jan 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions modules/abstract-utxo/src/abstractUtxoCoin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ import {
import { assertFixedScriptWalletAddress } from './address/fixedScript';
import { isSdkBackend, ParsedTransaction, SdkBackend } from './transaction/types';
import { decodePsbtWith, encodeTransaction, stringToBufferTryFormats } from './transaction/decode';
import { toBip32Triple, UtxoKeychain } from './keychains';
import { fetchKeychains, toBip32Triple, UtxoKeychain } from './keychains';
import { verifyKeySignature, verifyUserPublicKey } from './verifyKey';
import { getPolicyForEnv } from './descriptor/validatePolicy';
import { signTransaction } from './transaction/signTransaction';
Expand Down Expand Up @@ -875,8 +875,16 @@ export abstract class AbstractUtxoCoin
* @param params
*/
override async explainTransaction<TNumber extends number | bigint = number>(
params: ExplainTransactionOptions<TNumber>
params: ExplainTransactionOptions<TNumber>,
wallet?: IWallet
): Promise<TransactionExplanation> {
if (!params.pubs) {
// if no pubs are provided, opportunistically fetch the keychains from the wallet
if (wallet) {
const keychains = await fetchKeychains(this, wallet);
params.pubs = toBip32Triple(keychains).map((k) => k.neutered().toBase58()) as Triple<string>;
}
}
return explainTx(this.decodeTransactionFromPrebuild(params), params, this.name);
}

Expand Down
5 changes: 4 additions & 1 deletion modules/sdk-core/src/bitgo/baseCoin/iBaseCoin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -583,7 +583,10 @@ export interface IBaseCoin {
backup: string;
bitgo: string;
}>;
explainTransaction(options: Record<string, any>): Promise<ITransactionExplanation<any, string | number> | undefined>;
explainTransaction(
options: Record<string, any>,
wallet?: IWallet
): Promise<ITransactionExplanation<any, string | number> | undefined>;
verifyTransaction(params: VerifyTransactionOptions): Promise<boolean>;
verifyAddress(params: VerifyAddressOptions): Promise<boolean>;
isWalletAddress(params: VerifyAddressOptions | TssVerifyAddressOptions, wallet?: IWallet): Promise<boolean>;
Expand Down
2 changes: 1 addition & 1 deletion modules/sdk-core/src/bitgo/staking/stakingWallet.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -405,7 +405,7 @@ export class StakingWallet implements IStakingWallet {
return;
}

const explainedTransaction = await coin.explainTransaction(result);
const explainedTransaction = await coin.explainTransaction(result, this.wallet);
const mismatchErrors: string[] = [];

if (buildParams?.recipients && buildParams.recipients.length > 0) {
Expand Down
Loading