Skip to content

fix!: bump BitGo SDK and fix UTXO multisig sendMany #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mohammadalfaiyazbitgo merged 1 commit into from
Apr 23, 2026
Merged

fix!: bump BitGo SDK and fix UTXO multisig sendMany #192

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5,474 changes: 2,043 additions & 3,431 deletions package-lock.json
View file
Open in desktop

Large diffs are not rendered by default.

153 changes: 77 additions & 76 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,80 +28,80 @@
"@api-ts/response": "^2.1.0",
"@api-ts/superagent-wrapper": "^1.3.3",
"@api-ts/typed-express-router": "2.0.0",
"@bitgo-beta/abstract-cosmos": "1.0.1-beta.1212",
"@bitgo-beta/abstract-eth": "1.0.2-beta.1461",
"@bitgo-beta/abstract-utxo": "1.1.1-beta.1464",
"@bitgo-beta/sdk-api": "1.10.1-beta.1230",
"@bitgo-beta/sdk-coin-ada": "2.3.14-beta.1229",
"@bitgo-beta/sdk-coin-algo": "1.3.19-beta.1229",
"@bitgo-beta/sdk-coin-apt": "1.0.1-beta.671",
"@bitgo-beta/sdk-coin-arbeth": "1.0.1-beta.1085",
"@bitgo-beta/sdk-coin-asi": "1.0.1-beta.318",
"@bitgo-beta/sdk-coin-atom": "3.1.2-beta.1227",
"@bitgo-beta/sdk-coin-avaxc": "1.1.1-beta.1455",
"@bitgo-beta/sdk-coin-avaxp": "3.5.10-beta.1228",
"@bitgo-beta/sdk-coin-baby": "1.0.1-beta.570",
"@bitgo-beta/sdk-coin-bch": "1.1.1-beta.1456",
"@bitgo-beta/sdk-coin-bcha": "1.1.1-beta.1455",
"@bitgo-beta/sdk-coin-bera": "1.0.1-beta.1084",
"@bitgo-beta/sdk-coin-bld": "1.0.1-beta.1189",
"@bitgo-beta/sdk-coin-bsc": "1.0.1-beta.1455",
"@bitgo-beta/sdk-coin-bsv": "1.1.1-beta.1455",
"@bitgo-beta/sdk-coin-btc": "1.0.2-beta.1456",
"@bitgo-beta/sdk-coin-btg": "1.1.1-beta.1455",
"@bitgo-beta/sdk-coin-celo": "1.1.1-beta.1454",
"@bitgo-beta/sdk-coin-coredao": "1.0.0-beta.663",
"@bitgo-beta/sdk-coin-coreum": "1.0.1-beta.1071",
"@bitgo-beta/sdk-coin-cronos": "1.0.1-beta.363",
"@bitgo-beta/sdk-coin-cspr": "1.2.19-beta.1228",
"@bitgo-beta/sdk-coin-dash": "1.1.1-beta.1456",
"@bitgo-beta/sdk-coin-doge": "1.0.2-beta.1456",
"@bitgo-beta/sdk-coin-dot": "2.2.8-beta.1228",
"@bitgo-beta/sdk-coin-eos": "1.3.19-beta.1227",
"@bitgo-beta/sdk-coin-etc": "1.0.2-beta.1454",
"@bitgo-beta/sdk-coin-eth": "4.4.1-beta.1226",
"@bitgo-beta/sdk-coin-ethw": "20.0.76-beta.393",
"@bitgo-beta/sdk-coin-flr": "1.0.1-beta.570",
"@bitgo-beta/sdk-coin-hash": "1.0.1-beta.1186",
"@bitgo-beta/sdk-coin-hbar": "1.0.2-beta.1456",
"@bitgo-beta/sdk-coin-icp": "1.0.1-beta.583",
"@bitgo-beta/sdk-coin-initia": "1.1.1-beta.343",
"@bitgo-beta/sdk-coin-injective": "1.1.3-beta.1180",
"@bitgo-beta/sdk-coin-islm": "1.0.1-beta.1083",
"@bitgo-beta/sdk-coin-ltc": "1.1.1-beta.1456",
"@bitgo-beta/sdk-coin-mon": "1.0.1-beta.399",
"@bitgo-beta/sdk-coin-near": "1.3.19-beta.1226",
"@bitgo-beta/sdk-coin-oas": "1.0.1-beta.665",
"@bitgo-beta/sdk-coin-opeth": "1.0.1-beta.1082",
"@bitgo-beta/sdk-coin-osmo": "1.0.1-beta.1210",
"@bitgo-beta/sdk-coin-polygon": "1.0.2-beta.1455",
"@bitgo-beta/sdk-coin-polyx": "1.0.1-beta.428",
"@bitgo-beta/sdk-coin-rbtc": "1.1.1-beta.1454",
"@bitgo-beta/sdk-coin-rune": "1.0.0-beta.694",
"@bitgo-beta/sdk-coin-sei": "1.0.1-beta.1182",
"@bitgo-beta/sdk-coin-sgb": "1.1.1-beta.570",
"@bitgo-beta/sdk-coin-sol": "2.4.3-beta.1225",
"@bitgo-beta/sdk-coin-soneium": "1.0.1-beta.379",
"@bitgo-beta/sdk-coin-stt": "1.0.1-beta.388",
"@bitgo-beta/sdk-coin-stx": "1.1.1-beta.1460",
"@bitgo-beta/sdk-coin-sui": "3.0.3-beta.1225",
"@bitgo-beta/sdk-coin-tao": "1.0.0-beta.592",
"@bitgo-beta/sdk-coin-tia": "3.1.8-beta.197",
"@bitgo-beta/sdk-coin-ton": "1.0.1-beta.1093",
"@bitgo-beta/sdk-coin-trx": "1.0.2-beta.1459",
"@bitgo-beta/sdk-coin-vet": "1.0.1-beta.343",
"@bitgo-beta/sdk-coin-wemix": "1.0.1-beta.563",
"@bitgo-beta/sdk-coin-world": "1.0.1-beta.389",
"@bitgo-beta/sdk-coin-xdc": "1.0.1-beta.570",
"@bitgo-beta/sdk-coin-xlm": "2.0.5-beta.1225",
"@bitgo-beta/sdk-coin-xrp": "1.1.1-beta.1458",
"@bitgo-beta/sdk-coin-xtz": "1.1.1-beta.1458",
"@bitgo-beta/sdk-coin-zec": "1.1.1-beta.1456",
"@bitgo-beta/sdk-coin-zeta": "1.0.1-beta.1147",
"@bitgo-beta/sdk-coin-zketh": "1.0.1-beta.1012",
"@bitgo-beta/sdk-core": "8.2.1-beta.1231",
"@bitgo-beta/sdk-lib-mpc": "8.2.0-beta.1223",
"@bitgo-beta/statics": "15.1.1-beta.1234",
"@bitgo-beta/abstract-cosmos": "1.0.1-beta.1689",
"@bitgo-beta/abstract-eth": "1.0.2-beta.1938",
"@bitgo-beta/abstract-utxo": "1.1.1-beta.1941",
"@bitgo-beta/sdk-api": "1.10.1-beta.1707",
"@bitgo-beta/sdk-coin-ada": "2.3.14-beta.1706",
"@bitgo-beta/sdk-coin-algo": "2.8.9-beta.186",
"@bitgo-beta/sdk-coin-apt": "1.0.1-beta.1148",
"@bitgo-beta/sdk-coin-arbeth": "1.0.1-beta.1561",
"@bitgo-beta/sdk-coin-asi": "1.0.1-beta.795",
"@bitgo-beta/sdk-coin-atom": "3.1.2-beta.1704",
"@bitgo-beta/sdk-coin-avaxc": "1.1.1-beta.1931",
"@bitgo-beta/sdk-coin-avaxp": "5.7.3-beta.20",
"@bitgo-beta/sdk-coin-baby": "1.0.1-beta.1047",
"@bitgo-beta/sdk-coin-bch": "1.1.1-beta.1932",
"@bitgo-beta/sdk-coin-bcha": "1.1.1-beta.1931",
"@bitgo-beta/sdk-coin-bera": "1.0.1-beta.1560",
"@bitgo-beta/sdk-coin-bld": "1.0.1-beta.1666",
"@bitgo-beta/sdk-coin-bsc": "1.0.1-beta.1931",
"@bitgo-beta/sdk-coin-bsv": "1.1.1-beta.1931",
"@bitgo-beta/sdk-coin-btc": "1.0.2-beta.1931",
"@bitgo-beta/sdk-coin-btg": "1.1.1-beta.1931",
"@bitgo-beta/sdk-coin-celo": "1.1.1-beta.1930",
"@bitgo-beta/sdk-coin-coredao": "1.0.0-beta.1139",
"@bitgo-beta/sdk-coin-coreum": "1.0.1-beta.1548",
"@bitgo-beta/sdk-coin-cronos": "1.0.1-beta.839",
"@bitgo-beta/sdk-coin-cspr": "1.2.19-beta.1704",
"@bitgo-beta/sdk-coin-dash": "1.1.1-beta.1932",
"@bitgo-beta/sdk-coin-doge": "1.0.2-beta.1932",
"@bitgo-beta/sdk-coin-dot": "2.2.8-beta.1704",
"@bitgo-beta/sdk-coin-eos": "1.3.19-beta.1702",
"@bitgo-beta/sdk-coin-etc": "1.0.2-beta.1930",
"@bitgo-beta/sdk-coin-eth": "4.4.1-beta.1702",
"@bitgo-beta/sdk-coin-ethw": "20.0.76-beta.869",
"@bitgo-beta/sdk-coin-flr": "1.0.1-beta.1046",
"@bitgo-beta/sdk-coin-hash": "1.0.1-beta.1662",
"@bitgo-beta/sdk-coin-hbar": "1.0.2-beta.1932",
"@bitgo-beta/sdk-coin-icp": "1.0.1-beta.1059",
"@bitgo-beta/sdk-coin-initia": "1.1.1-beta.818",
"@bitgo-beta/sdk-coin-injective": "1.1.3-beta.1656",
"@bitgo-beta/sdk-coin-islm": "1.0.1-beta.1559",
"@bitgo-beta/sdk-coin-ltc": "1.1.1-beta.1932",
"@bitgo-beta/sdk-coin-mon": "1.0.1-beta.875",
"@bitgo-beta/sdk-coin-near": "1.3.19-beta.1702",
"@bitgo-beta/sdk-coin-oas": "1.0.1-beta.1141",
"@bitgo-beta/sdk-coin-opeth": "1.0.1-beta.1558",
"@bitgo-beta/sdk-coin-osmo": "1.0.1-beta.1686",
"@bitgo-beta/sdk-coin-polygon": "1.0.2-beta.1931",
"@bitgo-beta/sdk-coin-polyx": "1.0.1-beta.904",
"@bitgo-beta/sdk-coin-rbtc": "1.1.1-beta.1930",
"@bitgo-beta/sdk-coin-rune": "1.0.0-beta.1170",
"@bitgo-beta/sdk-coin-sei": "1.0.1-beta.1658",
"@bitgo-beta/sdk-coin-sgb": "1.1.1-beta.1046",
"@bitgo-beta/sdk-coin-sol": "7.6.4-beta.351",
"@bitgo-beta/sdk-coin-soneium": "1.0.1-beta.855",
"@bitgo-beta/sdk-coin-stt": "1.0.1-beta.864",
"@bitgo-beta/sdk-coin-stx": "1.1.1-beta.1936",
"@bitgo-beta/sdk-coin-sui": "3.0.3-beta.1701",
"@bitgo-beta/sdk-coin-tao": "1.0.0-beta.1068",
"@bitgo-beta/sdk-coin-tia": "3.1.8-beta.673",
"@bitgo-beta/sdk-coin-ton": "1.0.1-beta.1569",
"@bitgo-beta/sdk-coin-trx": "1.0.2-beta.1935",
"@bitgo-beta/sdk-coin-vet": "1.0.1-beta.819",
"@bitgo-beta/sdk-coin-wemix": "1.0.1-beta.1039",
"@bitgo-beta/sdk-coin-world": "1.0.1-beta.865",
"@bitgo-beta/sdk-coin-xdc": "1.0.1-beta.1046",
"@bitgo-beta/sdk-coin-xlm": "2.0.5-beta.1700",
"@bitgo-beta/sdk-coin-xrp": "1.1.1-beta.1933",
"@bitgo-beta/sdk-coin-xtz": "1.1.1-beta.1934",
"@bitgo-beta/sdk-coin-zec": "1.1.1-beta.1932",
"@bitgo-beta/sdk-coin-zeta": "1.0.1-beta.1623",
"@bitgo-beta/sdk-coin-zketh": "1.0.1-beta.1488",
"@bitgo-beta/sdk-core": "8.2.1-beta.1708",
"@bitgo-beta/sdk-lib-mpc": "8.2.0-beta.1703",
"@bitgo-beta/statics": "15.1.1-beta.1714",
"@bitgo/wasm-miniscript": "2.0.0-beta.7",
"@commitlint/config-conventional": "^19.8.1",
"@ethereumjs/tx": "^3.3.0",
Expand All @@ -120,7 +120,6 @@
"zod": "^3.25.48"
},
"overrides": {
"@bitgo-beta/sdk-core": "8.2.1-beta.1231",
Copy link
Copy Markdown
Contributor Author

@pranishnepal pranishnepal Apr 22, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed this - seems it was added in #133

Keeping it causes conflicts

"elliptic": "^6.6.1",
"expo": "^48.0.0",
"form-data": "^4.0.4",
Expand All @@ -136,7 +135,9 @@
"got": "^12.1.0",
"store2": "^2.14.4",
"tar": "^7.5.11",
"basic-ftp": "^5.2.0",
"basic-ftp": "^5.3.0",
Comment thread
mohammadalfaiyazbitgo marked this conversation as resolved.
"@xmldom/xmldom": "^0.9.9",
"protobufjs": "^7.5.5",
"flatted": "^3.4.0",
"serialize-javascript": "^7.0.3",
"@isaacs/brace-expansion": "^5.0.1",
Expand Down
2 changes: 1 addition & 1 deletion src/__tests__/api/advancedWalletManager/recoveryMultisigTransaction.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ describe('UTXO recovery', () => {

const unsignedSweepPrebuildTx = {
txHex:
'0100000001edd7a583fef5aabf265e6dca24452581a3cca2671a1fa6b4e404bccb6ff4c83b0000000000ffffffff01780f0000000000002200202120dcf53e62a4cc9d3843993aa2258bd14fbf911a4ea4cf4f3ac840f417027900000000',
'70736274ff01005e0100000001edd7a583fef5aabf265e6dca24452581a3cca2671a1fa6b4e404bccb6ff4c83b0000000000ffffffff01780f0000000000002200202120dcf53e62a4cc9d3843993aa2258bd14fbf911a4ea4cf4f3ac840f4170279000000000001012ba00f00000000000022002008da4d49c618c6a00dc86a962f9c452dc0151653d2630470dcf8375a9f6496a501030401000000010569522103a1c425fd9b169e6ab5ed3de596acb777ccae0cda3d91256238b5e739a3f14aae210222a76697605c890dc4365132f9ae0d351952a1aad7eecf78d9923766dbe74a1e21033b21c0758ffbd446204914fa1d1c5921e9f82c2671dac89737666aa9375973e953ae22060222a76697605c890dc4365132f9ae0d351952a1aad7eecf78d9923766dbe74a1e14502e31ca000000000000000014000000000000002206033b21c0758ffbd446204914fa1d1c5921e9f82c2671dac89737666aa9375973e9146700d77100000000000000001400000000000000220603a1c425fd9b169e6ab5ed3de596acb777ccae0cda3d91256238b5e739a3f14aae14c2d0eb0a000000000000000014000000000000000000',
Comment thread
mohammadalfaiyazbitgo marked this conversation as resolved.
txInfo: {
unspents: [
{
Expand Down
36 changes: 36 additions & 0 deletions src/__tests__/api/advancedWalletManager/signMultisigTransaction.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,4 +118,40 @@ describe('signMultisigTransaction', () => {

kmsNock.done();
});

it('should sign a tbtc PSBT when walletPubs are provided', async () => {
const txHexPrefix = '70736274ff'; // PSBT magic bytes
const userPub =
'xpub661MyMwAqRbcF3g1sUm7T5pN8ViCr9bS6XiQbq7dVXFdPEGYfhGgjjV2AFxTYVWik29y7NHmCZjWYDkt4RGw57HNYpHnoHeeqJV6s8hwcsV';
const backupPub =
'xpub661MyMwAqRbcEywGPF6Pg1FDUtHGyxsn7nph8dcy8GFLKvQ8hSCKgUm8sNbJhegDbmLtMpMnGZtrqfRXCjeDtfJ2UGDSzNTkRuvAQ5KNPcH';
const bitgoPub =
'xpub661MyMwAqRbcGcBurxn9ptqqKGmMhnKa8D7TeZkaWpfQNTeG4qKEJ67eb6Hy58kZBwPHqjUt5iApUwvFVk9ffQYaV42RRom2p7yU5bcCwpq';

const txHex = `${txHexPrefix}01005e0100000001edd7a583fef5aabf265e6dca24452581a3cca2671a1fa6b4e404bccb6ff4c83b0000000000ffffffff01780f0000000000002200202120dcf53e62a4cc9d3843993aa2258bd14fbf911a4ea4cf4f3ac840f4170279000000000001012ba00f00000000000022002008da4d49c618c6a00dc86a962f9c452dc0151653d2630470dcf8375a9f6496a501030401000000010569522103a1c425fd9b169e6ab5ed3de596acb777ccae0cda3d91256238b5e739a3f14aae210222a76697605c890dc4365132f9ae0d351952a1aad7eecf78d9923766dbe74a1e21033b21c0758ffbd446204914fa1d1c5921e9f82c2671dac89737666aa9375973e953ae22060222a76697605c890dc4365132f9ae0d351952a1aad7eecf78d9923766dbe74a1e14502e31ca000000000000000014000000000000002206033b21c0758ffbd446204914fa1d1c5921e9f82c2671dac89737666aa9375973e9146700d77100000000000000001400000000000000220603a1c425fd9b169e6ab5ed3de596acb777ccae0cda3d91256238b5e739a3f14aae14c2d0eb0a000000000000000014000000000000000000`;

const kmsNock = nock(kmsUrl).get(`/key/${userPub}`).query({ source: 'user' }).reply(200, {
prv: 'xprv9s21ZrQH143K2ZbYmTE75wsdaTsiSgsajJnooSi1wBieWRwQ89xSBwAYK1VJR795Y8XFCCXYHHs4sk2Heg6dkX3CHMBq5bw8DwBWByWx883',
pub: userPub,
source: 'user',
type: 'independent',
});

const response = await agent
.post(`/api/tbtc/multisig/sign`)
.set('Authorization', `Bearer ${accessToken}`)
.send({
source: 'user',
pub: userPub,
txPrebuild: { txHex },
walletPubs: [userPub, backupPub, bitgoPub],
});

response.status.should.equal(200);
// BitGoPsbt path returns { txHex } (signed PSBT hex), not { halfSigned }
response.body.should.have.property('txHex');
response.body.txHex.should.startWith(txHexPrefix);

kmsNock.done();
});
});
Loading
Loading