Assignment1#1
Open
BitaEt wants to merge 4 commits into
Open
Conversation
TDerig23
reviewed
Sep 9, 2022
TDerig23
reviewed
Sep 9, 2022
| #Other models - SVC and Logistic Regression | ||
| svclassifier = SVC(kernel='poly', degree=8) | ||
| svclassifier.fit(X_train_sc, y_train) | ||
|
|
There was a problem hiding this comment.
Again the code runs fine here and everything ran right, but print out the values you get from the classifier.fit so we can see if the models are accurate or not
Owner
Author
There was a problem hiding this comment.
Well the code includes confusion matrix for both models which shows accuracy, precision, recall and F1 score.
TDerig23
reviewed
Sep 9, 2022
| fig4 = px.violin(df, y="PetalLengthCm", color="Species", violinmode='overlay', hover_data=df.columns) | ||
|
|
||
| fig5 = px.ecdf(df, x="SepalLengthCm", y="SepalWidthCm", color="Species", ecdfnorm=None) | ||
|
|
There was a problem hiding this comment.
do fig1.show(),fig2.show(), etc so we can see the plots. the code runs fine but they don't show up unless you have them
Owner
Author
There was a problem hiding this comment.
Thanks for the note! I commented fig.show() to the code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python code should be in Assignment1.py file