Fixed padding to prevent valid signatures from failing in lnurl-auth …#48
Open
mdance wants to merge 1 commit intoBitcoinPHP:masterfrom
Open
Fixed padding to prevent valid signatures from failing in lnurl-auth …#48mdance wants to merge 1 commit intoBitcoinPHP:masterfrom
mdance wants to merge 1 commit intoBitcoinPHP:masterfrom
Conversation
Contributor
|
Thank you for your pull request, it looks good, Can you give some more insight on why the padding is different for inurl-auth? |
Author
|
I dont have enough understanding of the checkSignaturePoints method to understand why, but I am consistently seeing R: 00abcdefg Seems to always be missing 2 leading 0, the previous check was expecting the strlen to be <64, strlen(R) is consistently 66 Would be happy to do a screenshare, and debug session to run you through some scenarios |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…verifications