Move from jekyll to render-engine#717
Conversation
get template path to index working
Co-authored-by: ngodfrey <ngodfrey@protonmail.com>
* fixed css link * fixed js link * fixed js link added About page --------- Co-authored-by: ngodfrey <ngodfrey@protonmail.com>
* feat: included navigation items to header * fix: navigation urls and nav-current class
* fixed css link * fixed js link * fixed js link added About page * updating events --------- Co-authored-by: ngodfrey <ngodfrey@protonmail.com>
* Add time to date field * Update from Liquid to Jinja templating
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the website from Jekyll to Render Engine, removing legacy Jekyll configurations and files while adding new layouts, templates, and configurations (e.g. pyproject.toml, app.py) to support the Render Engine. Key changes include:
- Removal of Jekyll-specific files (_config.yml, Gemfile, etc.) and pages (e.g. events.md, blog/index.html).
- Introduction of new Render Engine configurations and updated layouts/templates.
- Updates to static assets and CSS to support the new design.
Reviewed Changes
Copilot reviewed 47 out of 100 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| website-issues-report.md | New issues report file added for providing SEO/HTML diagnostic details. |
| support.md | New markdown content for the Support page. |
| support.html, leadership.md, events.md, etc. | Deleted legacy Jekyll pages now replaced by Render Engine pages. |
| pyproject.toml, app.py | New configuration files and app definitions for render-engine integration. |
| Various _layouts and _includes | Updated templates and partials reflecting new syntax and structure. |
| assets/css/bpd.css | CSS updates to support new styling; includes a correction for a CSS declaration. |
| _data/leadership.yaml & foundational_supporters.json | Data updates to support revised team and supporter displays. |
| .github/workflows/teahouse.yml | New CI/CD workflow for publishing the site with Render Engine. |
| {% for sponsored_event in site.data.events.sponsored_events %} | ||
| <article> | ||
| <h2> | ||
| <a href="{{ conference.url }}">{{ conference.name }}</a> |
There was a problem hiding this comment.
Within the loop that iterates over 'sponsored_events', the variable 'conference' is still being referenced; update it to use 'sponsored_event' for consistency.
There was a problem hiding this comment.
Should be a new issue....
| @@ -0,0 +1,7 @@ | |||
| <li> | |||
| <a {% unless entry.platform="" ="rss" %}rel="me" {% endunless %}href="{{ entry.user_url }}" target="_blank" title="{{ entry.title | default: entry.platform }}"> | |||
There was a problem hiding this comment.
The condition in the 'unless' tag is malformed; it likely should be written as {% unless entry.platform == "rss" %}.
| <a {% unless entry.platform="" ="rss" %}rel="me" {% endunless %}href="{{ entry.user_url }}" target="_blank" title="{{ entry.title | default: entry.platform }}"> | |
| <a {% unless entry.platform == "rss" %}rel="me" {% endunless %}href="{{ entry.user_url }}" target="_blank" title="{{ entry.title | default: entry.platform }}"> |
There was a problem hiding this comment.
This should just be removed... but not breaking anything... NEW ISSUE.
| {% assign lang = locale[0] %} | ||
| {% assign locale_name = locale[1][lang].locale_name %} | ||
| {% if page.lang == lang %} | ||
| {% set locales = locales | sort %} {% for locale in locales %} {% set lang = locale[0] %} {% set locale_name = locale[1][lang].locale_name %} {% if lang == lang %} |
There was a problem hiding this comment.
The condition comparing 'lang' to itself is always true; consider comparing the loop variable to the current page language (e.g. {% if page.lang == lang %}).
There was a problem hiding this comment.
new issue created
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -0,0 +1,94 @@ | |||
| <!-- Load Leaflet CSS and JS from CDN --> | |||
| <link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/leaflet/1.9.4/leaflet.css" /> | |||
| <script src="https://cdnjs.cloudflare.com/ajax/libs/leaflet/1.9.4/leaflet.js"></script> | |||
Check warning
Code scanning / CodeQL
Inclusion of functionality from an untrusted source Medium
There was a problem hiding this comment.
either add integrity check or download and call from local source
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
dragid10
left a comment
dragid10
left a comment
There was a problem hiding this comment.
Maintainers are aware of failing tests and are content with merging as-is. We expect a future update to render-engine will fix our tests
Issue Link 🔗:
Issue: #[Issue_Number]
Type of Change
Description 📋
What: Provide an overview of the issue this PR addresses. Explain the context and background information.
Why: Describe why the changes are being made. Highlight key updates, new features, or bug fixes.
How: Explain how these changes will affect the project or end-users.
Checklist ✅
pre-commit run --allAdditional Notes & Screenshots
Add any additional notes or comments that might be helpful for the reviewers.