removes playwright to test against output#860
Merged
kjaymiller merged 3 commits intogh-pagesfrom Mar 23, 2026
Merged
Conversation
Contributor
Author
|
Tests don't pass but they weren't passing before |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
kjaymiller
commented
Mar 23, 2026
.github/workflows/playwright.yml
Outdated
| jobs: | ||
| test: | ||
| timeout-minutes: 30 | ||
| timeout-minutes: 10 |
Contributor
Author
There was a problem hiding this comment.
Suggested change
| timeout-minutes: 10 |
kjaymiller
commented
Mar 23, 2026
.github/workflows/playwright.yml
Outdated
| version: "latest" | ||
| - name: Set up Python | ||
| run: uv python install 3.12 | ||
| run: uv python install 3.13 |
Contributor
Author
There was a problem hiding this comment.
Suggested change
| run: uv python install 3.13 | |
| run: uv python install 3.14 |
kjaymiller
commented
Mar 23, 2026
.github/workflows/playwright.yml
Outdated
| run: | | ||
| uv sync --extra dev | ||
| uv run playwright install --with-deps chromium | ||
| run: uv sync --extra dev |
Contributor
Author
There was a problem hiding this comment.
Suggested change
| run: uv sync --extra dev | |
| run: uv sync --dev prerelease allow |
kjaymiller
commented
Mar 23, 2026
Contributor
Author
There was a problem hiding this comment.
This doesn't need to be a part of this pr
kjaymiller
commented
Mar 23, 2026
Contributor
Author
There was a problem hiding this comment.
irrelevant to pr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Link 🔗:
Issue: #750
Type of Change
Description 📋
The playwright testing was unreliable in many ways and unecesary.
The website is statically built. We can build the site and test against the output
Why: Describe why the changes are being made. Highlight key updates, new features, or bug fixes.
How: Explain how these changes will affect the project or end-users.
Checklist ✅
pre-commit run --allAdditional Notes & Screenshots
Add any additional notes or comments that might be helpful for the reviewers.