Skip to content

Use rounding for display#2

Open
BlackVegetable wants to merge 10 commits intomasterfrom
v1.03-changes
Open

Use rounding for display#2
BlackVegetable wants to merge 10 commits intomasterfrom
v1.03-changes

Conversation

@BlackVegetable
Copy link
Copy Markdown
Owner

@BlackVegetable BlackVegetable commented Jan 5, 2017

This PR is for some changes for a real release version in a modern age. (spiffy!)

It should include, by the end:

  • Nerf of battle novas/supernovas to only give +50% to matches.
    • Correct rounding behavior for display of nova.
  • Some typo fixes in the new quest line.
  • Reputation instructions in the quest line (especially for the food purchase quest.)
  • The complete removal of the MSG from the game (it was broken and unintuitive.)

And optionally:

  • A Haggling bonus for the 4th PSI power
  • Better scaling for the Pilot skill

The optional items may invalidate old saves, which is why it would be better to include them now rather than when more people are using the mod and would have to restart.


This change is Reviewable

Internally, even if a non-integer is used for the value of matched gems, it seems to round it. However, when displayed, it will include the fractional portion of the match before rounding. This gets strange as it also doesn't include a decimal place making a match of 3 * 1.5 = 4.5 display as "45" instead of "4.5" or even "4". Rounding here seems to fix that.
Novae and Supernovae now only grant +50% matching bonus, down from +100% and +200%. The extra turn for Supernovae still exists. Previously this made the game very vulnerable to sheer luck wins/losses and was annoying for players wanting a strategic game.
The text has been updated (for English) to reflect the fact that novae and supernovae do not always give +100% and +200%.
No new content, and I'm unsure on bug fixes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant