Update PageSnippet to respect pretty url if site is using

.github/PULL_REQUEST_TEMPLATE.md

@@ -1,15 +1,15 @@
 <!--
 
 Before working on a contribution, you must determine on which branch you need to work:
-- Bug fix: choose the latest maintenance branch `11.2`
+- Bug fix: choose the latest maintenance branch `11.5`
 - Feature/Improvement: choose `11.x` 
 
 > All bug fixes merged into the latest maintenance branch are also merged to the current dev branch (`11.x`) on a regular basis.
 
 ## Please make sure your PR complies with all of the following points: 
 - [ ] Read and accept our [contributing guidelines](/CONTRIBUTING.md) before you submit a PR.
 - [ ] Features need to be proper documented in `doc/` 
-- [ ] Bugfixes need a short guide how to reproduce them -> target branch is the oldest supported maintenance branch, e.g. `11.2` (see Readme.md for the list of supported versions)
+- [ ] Bugfixes need a short guide how to reproduce them -> target branch is the oldest supported maintenance branch, e.g. `11.4` (see Readme.md for the list of supported versions)
 - [ ] Meet all coding standards (see PhpStan actions) 
 
 **Don't submit a PR if it doesn't comply, it'll be closed without a comment!**

.github/ci/files/config/bundles.php

@@ -23,7 +23,4 @@
     "Pimcore\\Bundle\\ApplicationLoggerBundle\\PimcoreApplicationLoggerBundle" => [
         "all" => TRUE
     ],
-    "Pimcore\\Bundle\\TinymceBundle\\PimcoreTinymceBundle" => [
-        "all" => TRUE
-    ],
 ];

.github/ci/files/config/packages/html_sanitizer.yaml

@@ -2,6 +2,7 @@ framework:
     html_sanitizer:
         sanitizers:
             pimcore.wysiwyg_sanitizer:
+                max_input_length: -1
                 allow_attributes:
                     pimcore_type: '*'
                     pimcore_id: '*'
@@ -10,7 +11,7 @@ framework:
                 allow_elements:
                     span: [ 'class', 'style', 'id' ]
                     div: [ 'class', 'style', 'id' ]
-                    p: [ 'class', 'style', 'id' ]
+                    p: [ 'class', 'style', 'id', 'dir', 'data-cell' ]
                     strong: 'class'
                     em: 'class'
                     h1: [ 'class', 'id' ]
@@ -19,14 +20,15 @@ framework:
                     h4: [ 'class', 'id' ]
                     h5: [ 'class', 'id' ]
                     h6: [ 'class', 'id' ]
+                    a: [ 'class', 'id', 'href', 'target', 'title', 'rel', 'style' ]
                     table: [ 'class', 'style', 'cellspacing', 'cellpadding', 'border', 'width', 'height', 'id' ]
                     colgroup: 'class'
                     col: [ 'class', 'style', 'id' ]
-                    thead: [ 'class', 'id' ]
-                    tbody: [ 'class', 'id' ]
-                    tr: [ 'class', 'id' ]
-                    td: [ 'class', 'id' ]
-                    th: [ 'class', 'id', 'scope' ]
+                    thead: [ 'class', 'id', 'style' ]
+                    tbody: [ 'class', 'id', 'style' ]
+                    tr: [ 'class', 'id', 'style', 'colspan', 'rowspan' ]
+                    td: [ 'class', 'id', 'style', 'colspan', 'rowspan', 'data-row', 'width', 'height' ]
+                    th: [ 'class', 'id', 'scope', 'style', 'colspan', 'rowspan', 'width', 'height' ]
                     ul: [ 'class', 'style', 'id' ]
                     li: [ 'class', 'style', 'id' ]
                     ol: [ 'class', 'style', 'id' ]
@@ -40,7 +42,8 @@ framework:
                     s: [ 'class', 'id' ]
                     iframe: [ 'frameborder', 'height', 'longdesc', 'name', 'sandbox', 'scrolling', 'src', 'title', 'width' ]
                     br: ''
-                    img: [ 'alt', 'style', 'src' ]
+                    img: [ 'class', 'alt', 'style', 'src' ]
+                    hr: ''
             pimcore.translation_sanitizer:
                 allow_attributes:
                     pimcore_type: '*'

.github/ci/files/public/index_test.php

@@ -19,7 +19,7 @@
 use Symfony\Component\Debug\Debug;
 use Symfony\Component\HttpFoundation\Request;
 
-include __DIR__ . "/../vendor/autoload_runtime.php";
+include __DIR__ . "/../vendor/autoload.php";
 
 define('PIMCORE_PROJECT_ROOT', __DIR__ . '/..');
 define('APP_ENV', 'test');
@@ -43,3 +43,4 @@
 $response->send();
 
 $kernel->terminate($request, $response);
+

.github/ci/scripts/symfony-require-dev.sh

@@ -36,6 +36,7 @@ composer require --no-update \
     symfony/security-core:${SYMFONY_VERSION} \
     symfony/security-http:${SYMFONY_VERSION} \
     symfony/serializer:${SYMFONY_VERSION} \
+    symfony/string:${SYMFONY_VERSION} \
     symfony/templating:${SYMFONY_VERSION} \
     symfony/translation:${SYMFONY_VERSION} \
     symfony/twig-bridge:${SYMFONY_VERSION} \
@@ -45,4 +46,4 @@ composer require --no-update \
     symfony/var-dumper:${SYMFONY_VERSION} \
     symfony/web-profiler-bundle:${SYMFONY_VERSION} \
     symfony/workflow:${SYMFONY_VERSION} \
-    symfony/yaml:${SYMFONY_VERSION}
+    symfony/yaml:${SYMFONY_VERSION}

.github/workflows/cla-check.yaml

@@ -0,0 +1,14 @@
+name: CLA check
+
+on:
+  issue_comment:
+    types: [created]
+  pull_request_target:
+    types: [opened, closed, synchronize]
+
+jobs:
+  cla-workflow:
+    uses: pimcore/workflows-collection-public/.github/workflows/reusable-cla-check.yaml@v1.3.0
+    if: (github.event.comment.body == 'recheck' || github.event.comment.body == 'I have read the CLA Document and I hereby sign the CLA') || github.event_name == 'pull_request_target'
+    secrets:
+      CLA_ACTION_ACCESS_TOKEN: ${{ secrets.CLA_ACTION_ACCESS_TOKEN }}

.github/workflows/codeception.yaml

@@ -2,6 +2,7 @@
 name: "Codeception Tests"
 
 on:
+    workflow_dispatch:
     schedule:
         -   cron: '0 3 * * *'
     pull_request:
@@ -35,19 +36,15 @@ permissions:
 jobs:
     codeception-tests:
         name: "Codeception tests"
-        runs-on: "ubuntu-20.04"
+        runs-on: "ubuntu-22.04"
         continue-on-error: ${{ matrix.experimental }}
         strategy:
             matrix:
                 include:
                     - { php-version: 8.3, database: "mariadb:11.2", dependencies: highest, experimental: false, storage: local, symfony: "", composer-options: "" }
                     - { php-version: 8.3, database: "mariadb:10.3", dependencies: lowest, experimental: false, storage: local, symfony: "", composer-options: "" }
-                    - { php-version: 8.2, database: "mariadb:10.5", dependencies: highest, experimental: false, storage: local, symfony: "", composer-options: "" }
-                    - { php-version: 8.2, database: "mariadb:10.11", dependencies: highest, experimental: false, storage: local, symfony: "", composer-options: "" }
-                    - { php-version: 8.2, database: "mariadb:10.11", dependencies: highest, experimental: true, storage: local, symfony: "6.4.x-dev", composer-options: "" }
-                    - { php-version: 8.1, database: "mariadb:10.7", dependencies: highest, experimental: false, storage: local, symfony: "", composer-options: "" }
-                    - { php-version: 8.1, database: "mysql:8.0", dependencies: lowest, experimental: false, storage: local, symfony: "", composer-options: "" }
-                    - { php-version: 8.1, database: "percona:8.0", dependencies: lowest, experimental: false, storage: minio, symfony: "", composer-options: "" }
+                    - { php-version: 8.4, database: "mariadb:10.5", dependencies: highest, experimental: false, storage: local, symfony: "", composer-options: "" }
+                    - { php-version: 8.4, database: "mariadb:10.11", dependencies: highest, experimental: false, storage: local, symfony: "", composer-options: "" }
 
         services:
             minio:

.github/workflows/composer-checks-outdated-monthly.yaml

@@ -0,0 +1,25 @@
+name: "Composer outdated check - monthly minor check"
+
+on:
+    workflow_dispatch:
+    schedule:
+        - cron:  '0 7 1 * *'
+
+permissions:
+  contents: read
+
+jobs:
+    composer-checks:
+        uses: pimcore/workflows-collection-public/.github/workflows/reusable-composer-checks.yaml@main
+        strategy:
+            fail-fast: false
+            matrix:
+                include:
+                    - { php-version: 8.4, branch: 12.x }
+                    - { php-version: 8.3, branch: 11.5 }
+        with:
+            php-version: ${{ matrix.php-version }}
+            branch: ${{ matrix.branch }}
+            ignore-list: "public"
+            version-type: "-m"
+        secrets: inherit

.github/workflows/composer-checks.yaml → .github/workflows/composer-checks-outdated.yaml

@@ -1,8 +1,9 @@
-
-name: "Composer Audit & Outdated"
+name: "Composer outdated check"
 
 on:
     workflow_dispatch:
+    schedule:
+        - cron:  '0 7 * * 5'
 
 permissions:
   contents: read
@@ -14,8 +15,10 @@ jobs:
             fail-fast: false
             matrix:
                 include:
-                    - { php-version: 8.1, branch: 10.6 }
-                    - { php-version: 8.2, branch: 11.x }
+                    - { php-version: 8.4, branch: 12.x }
+                    - { php-version: 8.3, branch: 11.5 }
         with:
             php-version: ${{ matrix.php-version }}
             branch: ${{ matrix.branch }}
+            ignore-list: "public"
+        secrets: inherit

.github/workflows/composer-checks-vulnerabilities.yaml

@@ -0,0 +1,25 @@
+name: "Composer vulnerabilities check"
+
+on:
+    workflow_dispatch:
+    schedule:
+        - cron:  '0 7 * * *'
+
+permissions:
+  contents: read
+
+jobs:
+    composer-checks:
+        uses: pimcore/workflows-collection-public/.github/workflows/reusable-composer-vulnerabilities.yaml@main
+        strategy:
+            fail-fast: false
+            matrix:
+                include:
+                    - { php-version: 8.4, branch: 12.x }
+                    - { php-version: 8.3, branch: 11.5 }
+        with:
+            php-version: ${{ matrix.php-version }}
+            branch: ${{ matrix.branch == 'default' && github.event.repository.default_branch || matrix.branch }}
+            private-repo: ${{ github.event.repository.private }}
+            ignore-list: "public"
+        secrets: inherit

.github/workflows/php-cs-fixer.yaml

@@ -1,4 +1,3 @@
-
 name: "PHP-CS-Fixer"
 
 on:
@@ -8,21 +7,14 @@ on:
             - "[0-9]+.x"
 
 permissions:
-  contents: read
+    contents: write
 
 jobs:
-    php-cs-fixer:
-        permissions:
-          contents: write  # for stefanzweifel/git-auto-commit-action to push code in repo
-        runs-on: ubuntu-latest
-        steps:
-            - uses: actions/checkout@v2
-              with:
-                  ref: ${{ github.head_ref }}
-
-            - name: PHP-CS-Fixer
-              uses: docker://oskarstark/php-cs-fixer-ga:latest
-
-            - uses: stefanzweifel/git-auto-commit-action@v4
-              with:
-                  commit_message: Apply php-cs-fixer changes
+    php-style:
+        uses: pimcore/workflows-collection-public/.github/workflows/reusable-php-cs-fixer.yaml@main
+        secrets:
+            PHP_CS_FIXER_GITHUB_TOKEN: ${{ secrets.PHP_CS_FIXER_GITHUB_TOKEN }}
+        with:
+            head_ref: ${{ github.event.pull_request.head.ref }}
+            repository: ${{ github.event.pull_request.head.repo.full_name }}
+            config_file: .php-cs-fixer.dist.php

.github/workflows/pull-request-checklist.yaml

@@ -16,9 +16,9 @@ jobs:
               env:
                   MESSAGE: |
                       ### Review Checklist
-                      - [ ] Target branch (`11.2` for bug fixes, others `11.x`)
+                      - [ ] Target branch (`11.5` for bug fixes, others `12.x`)
                       - [ ] Tests (if it's testable code, there should be a test for it - [get help](https://pimcore.com/docs/pimcore/current/Development_Documentation/Development_Tools_and_Details/Testing/Core_Tests.html))
-                      - [ ] Docs (every functionality needs to be documented, [see here](https://github.com/pimcore/pimcore/tree/11.x/doc)) 
+                      - [ ] Docs (every functionality needs to be documented, [see here](https://github.com/pimcore/pimcore/tree/12.x/doc)) 
                       - [ ] [Migration](https://pimcore.com/docs/pimcore/current/Development_Documentation/Development_Tools_and_Details/Migrations.html) incl. `install.sql` (e.g. if the database schema changes, ...) 
                       - [ ] Upgrade notes (deprecations, important information, migration hints, ...) 
                       - [ ] Label
@@ -32,4 +32,3 @@ jobs:
                         repo: context.repo.repo,
                         body: `${MESSAGE}`
                       })
-

.github/workflows/stale.yaml

@@ -6,37 +6,8 @@ on:
 
 permissions:
   contents: read
+  issues: write
 
 jobs:
-  stale:
-    permissions:
-      issues: write
-    runs-on: ubuntu-latest
-    steps:
-      - uses: actions/stale@v9
-        with:
-          days-before-issue-stale: 20
-          days-before-issue-close: -1
-          days-before-pr-stale: -1
-          days-before-pr-close: -1
-          exempt-all-milestones: true
-          exempt-issue-labels: 'Pimcore:Priority,Pimcore:Backlog,Pimcore:ToDo'
-          remove-stale-when-updated: false
-          stale-issue-label: 'PR Welcome'
-          operations-per-run: 200
-          stale-issue-message: >
-              Thanks a lot for reporting the issue.
-              We did not consider the issue as "Pimcore:Priority", "Pimcore:ToDo" or "Pimcore:Backlog",
-              so we're not going to work on that anytime soon.
-              Please create a pull request to fix the issue if this is a bug report.
-              We'll then review it as quickly as possible.
-              If you're interested in contributing a feature, please contact us
-              first here before creating a pull request. We'll then decide whether
-              we'd accept it or not.
-              Thanks for your understanding.
-          close-issue-message: >
-              Closed due to inactivity (365 days).
-              Please feel free to continue the discussion or provide the missing information on this issue,
-              we'll then reopen it if necessary.
-              Thanks a lot!
-
+  call-stale-workflow:
+    uses: pimcore/workflows-collection-public/.github/workflows/stale.yml@main

.github/workflows/static-analysis.yaml

@@ -40,11 +40,8 @@ jobs:
                 include:
                     - { php-version: "8.3", dependencies: "lowest", experimental: false, symfony: "", composer-options: "" }
                     - { php-version: "8.3", dependencies: "highest", experimental: false, symfony: "", composer-options: "" }
-                    - { php-version: "8.2", dependencies: "lowest", experimental: false, symfony: "", composer-options: "" }
-                    - { php-version: "8.2", dependencies: "highest", experimental: false, symfony: "", composer-options: "" }
-                    - { php-version: "8.2", dependencies: "highest", experimental: true, symfony: "6.4.x-dev", composer-options: "" }
-                    - { php-version: "8.1", dependencies: "lowest", experimental: false, symfony: "", composer-options: "" }
-                    - { php-version: "8.1", dependencies: "highest", experimental: false, symfony: "", composer-options: "" }
+                    - { php-version: "8.4", dependencies: "lowest", experimental: false, symfony: "", composer-options: "" }
+                    - { php-version: "8.4", dependencies: "highest", experimental: false, symfony: "", composer-options: "" }
 
         steps:
             - name: "Checkout code"
@@ -88,7 +85,7 @@ jobs:
 
             - name: "Upload baseline file"
               if: ${{ failure() }}
-              uses: actions/upload-artifact@v2
+              uses: actions/upload-artifact@v4
               with:
                   name: phpstan-baseline.neon
                   path: phpstan-baseline.neon

.github/workflows/sync-changes-scheduled.yml

@@ -6,12 +6,12 @@ on:
 
 jobs:
   sync-branches:
-    uses: pimcore/workflows-collection-public/.github/workflows/reusable-sync-changes.yaml@v1.0.0
+    uses: pimcore/workflows-collection-public/.github/workflows/reusable-sync-changes.yaml@main
     if: github.repository == 'pimcore/pimcore'
     strategy:
       fail-fast: false
       matrix:
-        ref: [{'base': '11.x', 'destination': '11.x'}, {'base': '11.2', 'destination': '11.2'}]
+        ref: [{'base': '12.x', 'destination': '12.x'}, {'base': '11.5', 'destination': '11.5'}]
     with:
       base_ref: ${{ matrix.ref.base }}
       ref_name: ${{ matrix.ref.destination }}
@@ -20,4 +20,4 @@ jobs:
     secrets:
       SYNC_TOKEN: ${{ secrets.SYNC_TOKEN }}
       GIT_NAME: ${{ secrets.GIT_NAME }}
-      GIT_EMAIL: ${{ secrets.GIT_EMAIL }}
+      GIT_EMAIL: ${{ secrets.GIT_EMAIL }}