This repository was archived by the owner on Dec 26, 2025. It is now read-only.
Do single rendering of FocusTrap after SetTitle#585
Open
heckradr wants to merge 1 commit intoBlazored:mainfrom
Open
Do single rendering of FocusTrap after SetTitle#585heckradr wants to merge 1 commit intoBlazored:mainfrom
heckradr wants to merge 1 commit intoBlazored:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for the following issue #565 and in addition to the closed PR #573
With this PR it is possible to use the SetTitle method again. Since only a single re-render is triggered when setting the title, it should not cause any perf issues due to multiple re-rendering.
P.S please forgive me, I'm not that familiar with PRs on GH yet. I hope I did that correctly 😃