This repository was archived by the owner on Dec 18, 2024. It is now read-only.
Fix for Flatpak apps and add Tym terminal lookup#226
Closed
PassiveLemon wants to merge 2 commits into
Closed
Conversation
Contributor
Author
|
Um nevermind there is a slight problem. It turns out that desktop files which have percent sign variables (like `pcmanfm %U) do not work. They only "worked" before because the sign was never actually included in the executable string as a result of the get_executable function. |
Contributor
Author
|
I've got some janky "solutions", each with pros and cons.
local executable = app:get_string("Exec")
executable = executable:match("^(.-)%%") or executable
local executable = app:get_string("Exec")
if executable:match("%%") then
executable = app_info.get_executable(app)
end
|
4cdb935 to
9d6843e
Compare
Contributor
Author
|
I opted for the first option for now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before the get_executable would only return the string "flatpak" from the Exec line while the new function returns the whole string.
I also added Tym terminal to the lookup.
I know #198 fixes this but that PR has been in works for ages now.