This repository was archived by the owner on Dec 14, 2019. It is now read-only.
Check if player is alive before dealing starve damage#10
Open
volkj wants to merge 1 commit intoBlockMen:masterfrom
Open
Check if player is alive before dealing starve damage#10volkj wants to merge 1 commit intoBlockMen:masterfrom
volkj wants to merge 1 commit intoBlockMen:masterfrom
Conversation
When a player dies of starvation it happens that chat message "You died" appears again and again if the player doesn't press Respawn button. With this edit the damage dealing function checks if the player has life available ( hp > 0) before dealing damage, leading to not execute the function again and again after the player is dead. It should solve problems with mods that prints death messages and drops inventory.
|
Instead of stopping damage after the hp drops below zero, how about using something like max(hp-damage, 0) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a player dies of starvation it happens that chat message "You died"
appears again and again if the player doesn't press Respawn button.
With this edit the damage dealing function checks if the player has life available ( hp > 0)
before dealing damage, leading to not execute the function again and again after the player is dead.
It should solve problems with mods that prints death messages and drops inventory.