Fix/alignment in swap tables

[zahorodnyi]

Rework swap table display logic to use the comfy-table crate and move display logic to separate crate
FIx: #45

[zahorodnyi]

@greptile review the PR according to the CONTRIBUTION.md

[greptile-apps]

Greptile Overview

Greptile Summary

This PR successfully refactors the swap table display logic to use the comfy-table crate, achieving better alignment and consistency with other CLI table displays in the codebase.

Key Changes:

• Moved three swap-related data structs (LocalSwapData, LocalCancellableSwap, LocalWithdrawableSwap) from function-local scope to module level in swap.rs
• Created three new display structs (ActiveSwapDisplay, CancellableSwapDisplay, WithdrawableSwapDisplay) with pre-formatted string fields
• Implemented builder functions (build_active_swaps_displays, build_cancellable_swaps_displays, build_withdrawable_swaps_displays) to transform business logic structs into display structs
• Added TableData trait implementations for the new display structs in tables.rs
• Replaced manual table formatting (using println! with format strings and dashes) with the unified render_table function that uses comfy-table

Architectural Benefits:

• Separation of Concerns: Business logic (data collection) is now separate from presentation logic (display formatting)
• Consistency: All swap tables now use the same rendering mechanism as other tables in the CLI (options, positions, etc.)
• Maintainability: Table formatting changes can be made in one place (tables.rs) rather than scattered across command implementations
• Testability: Display logic is now in separate, testable builder functions

Functional Correctness:

• All original data is preserved and displayed correctly
• Empty state handling remains unchanged (errors before attempting to display)
• Column headers and data alignment match the original format
• The distinction between SwapDisplay (for browsing remote swaps) and ActiveSwapDisplay (for taking local swaps) is maintained correctly

This refactoring addresses issue #45 by fixing table alignment issues and provides a cleaner, more maintainable codebase.

Confidence Score: 5/5

• This PR is safe to merge with no identified risks
• After thorough analysis of both changed files, commit history, and related codebase context, no logic errors, security vulnerabilities, or functional issues were found. The refactoring maintains exact functional parity with the original code while improving code organization and consistency. All data transformations are correct, error handling is preserved, and the changes follow existing patterns in the codebase. The single logical commit adheres to the repository's commit guidelines.
• No files require special attention

Important Files Changed

File Analysis

Filename	Score	Overview
crates/cli-client/src/cli/swap.rs	5/5	Refactored swap table display logic by moving structs to module level, creating dedicated display structs with pre-formatted strings, and implementing builder functions to transform data
crates/cli-client/src/cli/tables.rs	5/5	Added TableData implementations and display functions for three new swap display structs, following existing patterns

Sequence Diagram

sequenceDiagram
    participant User
    participant swap.rs
    participant Builder Functions
    participant Display Structs
    participant tables.rs
    participant comfy-table

    User->>swap.rs: Execute swap command (take/cancel/withdraw)
    swap.rs->>swap.rs: Collect LocalSwapData/LocalCancellableSwap/LocalWithdrawableSwap
    swap.rs->>Builder Functions: build_*_displays(local_data)
    Builder Functions->>Builder Functions: Format strings (format_settlement_asset, truncate_with_ellipsis, etc.)
    Builder Functions->>Display Structs: Create ActiveSwapDisplay/CancellableSwapDisplay/WithdrawableSwapDisplay
    Display Structs-->>Builder Functions: Return Vec<DisplayStruct>
    Builder Functions-->>swap.rs: Return displays
    swap.rs->>tables.rs: display_*_table(displays)
    tables.rs->>tables.rs: TableData::get_header()
    tables.rs->>tables.rs: TableData::to_row() for each item
    tables.rs->>comfy-table: render_table()
    comfy-table->>User: Formatted table output

Loading

[greptile-apps]

_{1 file reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

[zahorodnyi]

@greptile review the PR according to the CONTRIBUTION.md

[KyrylR]

ACK b4009e9