Simplex and LWK migration #68
Merged
Merged
Conversation
KyrylR
force-pushed
the
feature/finance-simplex-migration
branch
6 times, most recently
from
7adc935 to
070377a
Compare
KyrylR
force-pushed
the
feature/finance-simplex-migration
branch
from
0f67846 to
d964483
Compare
Collaborator
Author
|
Within the scope of this PR, none of the I believe it is OK to merge because NONE of the logic in the |
Collaborator
Author
|
Will create a follow up issues related to the refactoring The core idea of those is to:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is yet another big refactoring it does not touch at all the .simf files (except minor tweaks to how witness is passed)
Some .simf files were moved to crates/contracts/simf, besides it nothing else was changed