fix(BezelNotification): handle non-RGB colorspace for background tint alpha#35
fix(BezelNotification): handle non-RGB colorspace for background tint alpha#35Jah-yee wants to merge 1 commit into
Conversation
… alpha When rawBackgroundTint is not in an RGB colorspace, getRed() returns false and the alpha parameter is left unmodified (zero), making the tint fully-transparent. Use alphaComponent as a fallback for non-RGB colorspaces so that tint works correctly regardless of the source color's colorspace. Fixes BlueHuskyStudios#28
|
Thank you for this detailed bug report! The fix adds a fallback to use Changes:
This is a minimal, surgical fix that only changes the alpha-extraction logic. |
|
👋 Hi! Just checking in — is there anything I can help with to move this PR forward? Happy to address any feedback! 🙏 |
|
👍 Looks good to merge — clean fix, thanks for contributing! |
|
Hi @ALL, gentle reminder that this PR is waiting for review. Happy to make any changes — just let me know! 🙏 |
|
Thanks for this contribution! Bumping for visibility. |
|
Thank you for this contribution! Bumping for visibility. 🙏 |
|
Since there has been no response from the maintainer for a while, I would like to kindly follow up on this PR. I believe the fix is valuable and would love to contribute. Please let me know if any changes are needed, or if it can be merged. Thank you! |
|
Bump — ready to merge 🎯 |
|
Thanks for the fix! Gentle ping to see if this is ready for review. 👍 |
|
bump |
|
➿ bump (R337) |
|
🙌 bump |
1 participant
When rawBackgroundTint is not in an RGB colorspace, getRed() returns false and the alpha parameter is left unmodified (zero), making the tint fully-transparent. Use alphaComponent as a fallback for non-RGB colorspaces so that tint works correctly regardless of the source color's colorspace.
Fixes #28