Fix thread pool worker accounting drift in ThreadPoolExecutor#6
Draft
BoBiene wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
_freeThreadscounter from drifting under contention by ensuring it is only adjusted while a worker is actually waiting._runningThreadsand_poolwhen a worker exits.Description
_freeThreadsinInternalExecuteso the free-thread count is not manually manipulated when enqueuing tasks.RunPoolThreadwait loop so a worker increments_freeThreadsonly while insideMonitor.Waitand always decrements it in afinallyblock, and the worker dequeues and runs tasks after waking.try/finallyinRunPoolThreadto decrement_runningThreadsand remove the finished thread from_poolwhen a worker terminates, preserving consistent pool state.Testing
dotnet test SharpCifs.SMBv1.sln, but the test run failed in this environment becausedotnetis not installed.Codex Task