Adopt for new multi-threaded cursive capabilities#41
Closed
azat wants to merge 2 commits intoBonsaiDen:masterfrom
Closed
Adopt for new multi-threaded cursive capabilities#41azat wants to merge 2 commits intoBonsaiDen:masterfrom
azat wants to merge 2 commits intoBonsaiDen:masterfrom
Conversation
It is not always useful to always select some item (i.e. first by sorting order, by the way it is not even how it works natively since sort_by() applied after, and you need to call set_selected_item(0) for this). Consider csysdig, by default when you did not press anything it stick to the first item by sort order, and only if you select something (Up/Down) then it will stick to this item in the table. And this behaviour is better, since if you did not focus any item you want to look at the items sorted by the sort order. And I also made the Home button to cancel this selection.
In [1] cursive now requires Send + Sync, and the reason for this is:
The View now requires Send + Sync, to allow accessing or moving views between threads.
This prevents using Rc/RefCell, and may require using Arc/Mutex instead.
This should eventually open the way for more multi-threaded processing of the view tree.
[1]: gyscos/cursive@f1f25b1
|
This PR passes Would be nice to have it as version If so, it would allow and an updated EDIT: Note however that I haven't tried to run the program(s) to see if it works correctly. It just builds ok, that's all I know :) |
63 tasks
Author
|
Apparently fixed in a6952d7 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: this includes #40
In 1 cursive now requires Send + Sync, and the reason for this is: