移除了onCursorPos函数中对m_mouse_x和 m_mouse_y的判断#371
Open
sorvon wants to merge 1 commit intoBoomingTech:mainfrom
Open
移除了onCursorPos函数中对m_mouse_x和 m_mouse_y的判断#371sorvon wants to merge 1 commit intoBoomingTech:mainfrom
sorvon wants to merge 1 commit intoBoomingTech:mainfrom
Conversation
zDagwood
reviewed
Oct 21, 2022
zDagwood
left a comment
zDagwood
left a comment
There was a problem hiding this comment.
直接移除鼠标操作限制，会引入鼠标在界面外操作引起的意外情况出现。且仍然无法满足无限旋转的需求（鼠标位置仍然受屏幕限制）。想要实现无限旋转，可以考虑记录每帧的位移delta，把鼠标固定在某一位置
Contributor
Author
|
.左右仍然受屏幕大小限制 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
这里if (m_mouse_x >= 0.0f && m_mouse_y >= 0.0f)的限制会导致在editor_mode下使用右键旋转相机时，鼠标向左（或向上）移动一定距离后就无法继续向左（或向上）旋转相机了。