Skip to content

Fix: TextBox content not centered because of scrollviewer #2763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mergify merged 2 commits into from
Jun 19, 2024
Merged

Fix: TextBox content not centered because of scrollviewer #2763

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8ffccd6
Fix: TextBox content not centered because of scrollviewer
BornToBeRoot Jun 19, 2024
8ee6525
Docs: #2763
BornToBeRoot Jun 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions Source/NETworkManager/Resources/Styles/ScrollViewerStyles.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,11 @@
<RowDefinition Height="*" />
<RowDefinition Height="Auto" />
</Grid.RowDefinitions>
<ScrollContentPresenter Grid.ColumnSpan="1" Grid.RowSpan="1" />
<ScrollContentPresenter Grid.ColumnSpan="1" Grid.RowSpan="1"
Margin="{TemplateBinding Control.Padding}"
Content="{TemplateBinding ContentControl.Content}"
ContentTemplate="{TemplateBinding ContentControl.ContentTemplate}"
CanContentScroll="{TemplateBinding ScrollViewer.CanContentScroll}" />
<ScrollBar Name="PART_VerticalScrollBar"
HorizontalAlignment="Right"
Grid.Row="0"
Expand All @@ -43,7 +47,7 @@
</Style>

<Style TargetType="{x:Type ScrollViewer}" BasedOn="{StaticResource DefaultScrollViewer}" />

<Style x:Key="FadeOutScrollViewer" TargetType="{x:Type ScrollViewer}"
BasedOn="{StaticResource MahApps.Styles.ScrollViewer}">
<Setter Property="VerticalScrollBarVisibility" Value="Hidden" />
Expand All @@ -61,7 +65,11 @@
<RowDefinition Height="Auto" />
</Grid.RowDefinitions>
<ScrollContentPresenter Grid.Column="0" Grid.Row="0"
Grid.ColumnSpan="2" Grid.RowSpan="2" />
Grid.ColumnSpan="2" Grid.RowSpan="2"
Margin="{TemplateBinding Control.Padding}"
Content="{TemplateBinding ContentControl.Content}"
ContentTemplate="{TemplateBinding ContentControl.ContentTemplate}"
CanContentScroll="{TemplateBinding ScrollViewer.CanContentScroll}" />
<ScrollBar Name="PART_VerticalScrollBar"
HorizontalAlignment="Right"
Grid.Row="0"
Expand All @@ -77,7 +85,7 @@
Maximum="{TemplateBinding Property=ScrollableWidth}"
ViewportSize="{TemplateBinding Property=ViewportWidth}"
Orientation="Horizontal"
Visibility="{TemplateBinding Property=ComputedHorizontalScrollBarVisibility}"/>
Visibility="{TemplateBinding Property=ComputedHorizontalScrollBarVisibility}" />
</Grid>
</ControlTemplate>
</Setter.Value>
Expand Down
2 changes: 2 additions & 0 deletions Website/docs/changelog/next-release.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@ Release date: **xx.xx.2024**

## Bugfixes

- TextBox content not centered because of ScrollViewer issue. [#2763](https://github.com/BornToBeRoot/NETworkManager/pull/2763)

## Dependencies, Refactoring & Documentation

- Code cleanup & refactoring
Expand Down