Skip to content

Conversation

@Guzz-T
Copy link
Contributor

@Guzz-T Guzz-T commented Jan 5, 2026

Use the defintions introduced with #218

Further effects of these changes:

  • The name of a Parameter (and Calculation, Visiblities) data-vector is now lowercase (Parameter -> parameter).
    This gives an undefined field a name in lowercase letters, such as unknown_parameter_200.
    However, since we no longer check for upper and lower case, this is irrelevant for the user.
  • SHI field objects now contain the complete list of names instead of just the preferred name.

Next steps:

@github-actions
Copy link

github-actions bot commented Jan 5, 2026

Coverage

Coverage Report
FileStmtsMissCoverMissing
luxtronik
   __init__.py2401395%89–102, 251–252, 257
   __main__.py25250%3–62
   datatypes.py391299%57, 127
   discover.py58198%62
   parameters.py29197%46
luxtronik/scripts
   __init__.py16160%3–28
   discover_shi.py60600%8–98
   dump_changes.py43430%7–85
   dump_luxtronik.py26260%6–52
   dump_shi.py19190%7–40
   performance_shi.py63630%7–89
   watch_shi.py38380%7–85
luxtronik/shi
   contiguous.py135299%261–262
TOTAL221630986% 

Tests Skipped Failures Errors Time
363 0 💤 0 ❌ 0 🔥 14.312s ⏱️

@kbabioch kbabioch merged commit ea8aa80 into Bouni:main Jan 6, 2026
4 checks passed
@Guzz-T Guzz-T deleted the issue/221/definitions branch January 6, 2026 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants