Skip to content

fix(core-dart): detect C address sourceAccount and emit CONTRACT_SEND… #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
codeZe-us merged 2 commits into from
Mar 28, 2026
Merged

fix(core-dart): detect C address sourceAccount and emit CONTRACT_SEND… #182

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
caa9a2d
fix(core-dart): detect C address sourceAccount and emit CONTRACT_SEND…
Manuelshub Mar 27, 2026
632c628
fix(core-dart): correct invalid enum and field references in address_…
Manuelshub Mar 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions packages/core-dart/lib/src/routing/extract.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,22 @@ import 'result.dart';
import 'memo.dart';

RoutingResult extractRouting(RoutingInput input) {
if (input.sourceAccount != null && input.sourceAccount!.isNotEmpty) {
final source = parse(input.sourceAccount!);
if (source.kind == AddressKind.c) {
return RoutingResult(
routingSource: RoutingSource.none,
warnings: [
Warning(
code: WarningCode.contractSenderDetected,
severity: 'info',
message: 'Contract source detected. Routing state cleared.',
),
],
);
}
}

final parsed = parse(input.destination);

if (parsed.kind == null) {
Expand Down
8 changes: 4 additions & 4 deletions packages/core-dart/test/address_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ void main() {

test('identifies kind as m for valid muxed address', () {
const validMuxed =
'MAQAA5L65LSYH7CQWE7NNYSR42O4EFOA2OOYNDO643ZPNL6MQBBAAABBAAABBBAAABBAAA';
'MAYCUYT553C5LHVE2XPW5GMEJT4BXGM7AHMJWLAPZP53KJO7EIQACAAAAAAAAAAAAD672';
final result = StellarAddress.parse(validMuxed);
expect(result.kind, equals(AddressKind.m));
expect(result.raw, equals(validMuxed));
Expand All @@ -61,7 +61,7 @@ void main() {

test('identifies kind as m for valid muxed address', () {
const validMuxed =
'MAQAA5L65LSYH7CQWE7NNYSR42O4EFOA2OOYNDO643ZPNL6MQBBAAABBAAABBAAABBAAA';
'MAYCUYT553C5LHVE2XPW5GMEJT4BXGM7AHMJWLAPZP53KJO7EIQACAAAAAAAAAAAAD672';
final result = StellarAddress.parse(validMuxed);
expect(result.kind, equals(AddressKind.m));
});
Expand All @@ -70,8 +70,8 @@ void main() {
const validContractAddress =
'CAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAABSC4';
final result = StellarAddress.parse(validContractAddress);
expect(result.kind, equals(AddressKind.contract));
expect(result.value, equals(validContractAddress));
expect(result.kind, equals(AddressKind.c));
expect(result.raw, equals(validContractAddress));
});
});
}
Loading