Updated defacer to either use minimum or custom value #168
Conversation
|
🤖 Code Formatting Reminder Hello there! 👋 It looks like the code in this pull request might benefit from some formatting improvements. |
|
/format |
|
🤖 I will now format your code with black. Check the status here. |
There was a problem hiding this comment.
Pull request overview
This pull request adds the ability to configure the masking value used during image defacing operations. The defacing process can now either use the minimum value of each image (default behavior) or a custom global value specified by the user.
Changes:
- Added
masking_valueparameter to the baseDefacerclass, allowing users to specify a custom value for masked regions - Updated the
apply_maskmethod to use either the custom masking value or the image minimum when applying masks - Propagated the
masking_valueparameter to theQuickshearDefacersubclass
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| brainles_preprocessing/defacing/defacer.py | Added masking_value parameter to base class constructor and updated apply_mask logic to use either custom or minimum value |
| brainles_preprocessing/defacing/quickshear/quickshear.py | Added masking_value parameter to QuickshearDefacer constructor and passed it to parent class |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
nicmuenster
left a comment
nicmuenster
left a comment
There was a problem hiding this comment.
Different attempt at solving the issue in native python
|
🤖 Code Formatting Reminder Hello there! 👋 It looks like the code in this pull request might benefit from some formatting improvements. |
|
/format |
|
🤖 I will now format your code with black. Check the status here. |
|
🤖 Code Formatting Reminder Hello there! 👋 It looks like the code in this pull request might benefit from some formatting improvements. |
|
/format |
|
🤖 I will now format your code with black. Check the status here. |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
brainles_preprocessing/defacing/defacer.py:1
- The docstring for the
masking_valueparameter in__init__is missing. The parameter is defined at line 11 but there's no Args section in the docstring to document it.
from abc import ABC, abstractmethod
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
neuronflow
left a comment
neuronflow
left a comment
There was a problem hiding this comment.
@nicmuenster, should we maybe add a TODO in the comments that the fallback (currently falling back to min) might be something that users want to do on a modality-specific basis?
No description provided.