Skip to content

fix: rebase POS sales invoice GL entries on ERPNext 16 #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
my-dev-jour wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix: rebase POS sales invoice GL entries on ERPNext 16 #209

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 10 additions & 18 deletions pos_next/overrides/sales_invoice.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,11 +55,7 @@ class CustomSalesInvoice(SalesInvoice):

def make_pos_gl_entries(self, gl_entries):
"""
Override to add party information for wallet payment accounts.

The standard ERPNext implementation doesn't set party_type/party for
payment mode accounts, which causes validation errors for Receivable
accounts (like wallet accounts).
Rebase ERPNext 16 POS GL logic and add wallet-specific party info.
"""
if cint(self.is_pos):
skip_change_gl_entries = not _get_post_change_gl_entries_setting()
Expand All @@ -68,9 +64,12 @@ def make_pos_gl_entries(self, gl_entries):
if skip_change_gl_entries and payment_mode.account == self.account_for_change_amount:
payment_mode.base_amount -= flt(self.change_amount)

if payment_mode.amount:
against_voucher = self.name
if self.is_return and self.return_against and not self.update_outstanding_for_self:
against_voucher = self.return_against

if payment_mode.base_amount:
# POS, make payment entries
# Credit entry to debit_to (customer receivable)
gl_entries.append(
self.get_gl_dict(
{
Expand All @@ -82,9 +81,8 @@ def make_pos_gl_entries(self, gl_entries):
"credit_in_account_currency": payment_mode.base_amount
if self.party_account_currency == self.company_currency
else payment_mode.amount,
"against_voucher": self.return_against
if cint(self.is_return) and self.return_against
else self.name,
"credit_in_transaction_currency": payment_mode.amount,
"against_voucher": against_voucher,
"against_voucher_type": self.doctype,
"cost_center": self.cost_center,
},
Expand Down Expand Up @@ -112,6 +110,7 @@ def make_pos_gl_entries(self, gl_entries):
"debit_in_account_currency": payment_mode.base_amount
if payment_mode_account_currency == self.company_currency
else payment_mode.amount,
"debit_in_transaction_currency": payment_mode.amount,
"cost_center": self.cost_center,
},
payment_mode_account_currency,
Expand All @@ -120,14 +119,7 @@ def make_pos_gl_entries(self, gl_entries):
)

if not skip_change_gl_entries:
if hasattr(self, "get_gle_for_change_amount"):
# ERPNext v16+: Method renamed and returns a list of GL entries
# that needs to be extended to the main gl_entries list
gl_entries.extend(self.get_gle_for_change_amount())
else:
# ERPNext v15: Method takes gl_entries as parameter
# and appends change amount entries directly to it
self.make_gle_for_change_amount(gl_entries)
gl_entries.extend(self.get_gle_for_change_amount())

def get_party_and_party_type_for_pos_gl_entry(self, mode_of_payment, account):
"""
Expand Down