fix: preserve POS payment amounts during draft creation#215
Open
my-dev-jour wants to merge 1 commit intoBrainWise-DEV:developfrom
Open
fix: preserve POS payment amounts during draft creation#215my-dev-jour wants to merge 1 commit intoBrainWise-DEV:developfrom
my-dev-jour wants to merge 1 commit intoBrainWise-DEV:developfrom
Conversation
Contributor
Author
|
CI server passed. The remaining failing checks appear to be repo-level workflow/lint issues rather than regressions from this patch: the dependency audit cannot resolve ERPNext in CI, and the linter runs pre-commit with --all-files, which surfaces existing repo-wide formatting and Ruff issues outside this change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
set_missing_values()inupdate_invoice()paid_amountandbase_paid_amountafter restoring paymentsRoot Cause
ERPNext rebuilds POS payment rows during
set_missing_values()from POS Profile defaults. POSNext was calling that flow during draft creation without restoring the cashier-entered payment rows, so a paid sale could be saved/submitted with zeroed or replaced payments and end up unpaid.Validation
16.11.0staging with a real POS flowoutstanding_amount = 0py_compilein this workspaceNotes