fix: make partial payments transactional and use core currency setup#216
Open
my-dev-jour wants to merge 1 commit intoBrainWise-DEV:developfrom
Open
fix: make partial payments transactional and use core currency setup#216my-dev-jour wants to merge 1 commit intoBrainWise-DEV:developfrom
my-dev-jour wants to merge 1 commit intoBrainWise-DEV:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get_payment_entry(...)Why
add_payment_to_partial_invoice()currently claims rollback-safe behavior, butcreate_payment_entry()commits each submittedPayment Entryimmediately. If a later payment in the same batch fails, the API returns an error after already creating accounting side effects and then tries to clean up with compensating cancels.The current code also hardcodes both
paid_from_account_currencyandpaid_to_account_currencyfrominvoice.currency, which diverges from ERPNext's standardPayment Entrysetup and is wrong for multi-currency sites.What changed
get_payment_entry(...)so account currencies and references come from the standard pathmode_of_payment,reference_no,remarks, and explicit payment account selectionfrappe.db.commit()Validation
Payment Entryand then cancelled itPayment Entry Referencerows remained for the invoice after the failed requestpy_compilein this workspaceNotes
#197was runtime-validated on staging#199is a correctness fix aligned with ERPNext core, but staging is single-currency so that part was not runtime-proven there