fix: honor coupon apply_on in POS#219
Open
my-dev-jour wants to merge 1 commit intoBrainWise-DEV:developfrom
Open
fix: honor coupon apply_on in POS#219my-dev-jour wants to merge 1 commit intoBrainWise-DEV:developfrom
my-dev-jour wants to merge 1 commit intoBrainWise-DEV:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
apply_onwhen computing the discount amount in the POS coupon dialogGrand TotalandNet Totalcoupons produce different results as intendedRoot cause
CouponDialog.vuealways validatedmin_amountand calculated the coupon fromsubtotal, even when the coupon itself carriedapply_on = "Grand Total"orapply_on = "Net Total".The stale frontend calculation was then repeated in
useInvoice.applyDiscount(), which recalculated percentage discounts againstsubtotalagain.Validation
coupon.apply_onand always usedsubtotalgit diff --checkin this workspace