sod Expertise #356
Open
sod Expertise #356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed values in itemsTimewornExpertise from true to 1 for specific item IDs.
Owner
|
This PR now needs a bit of love after the big rework 🙈 |
Refactor enchant and item data structures for clarity and organization.
BreakBB
requested changes
Jan 12, 2026
Alessandro-Barbieri
force-pushed
the
expertise
branch
from
2b18420 to
24e3df6
Compare
Owner
|
This needs another rebase on |
BreakBB
requested changes
Jan 26, 2026
| width = 1.5, | ||
| hidden = function() | ||
| return (not ECS.IsWotlk) | ||
| return not (ECS.IsTbc or ECS.IsWotlk or ECS.IsSod) |
Owner
There was a problem hiding this comment.
Suggested change
| return not (ECS.IsTbc or ECS.IsWotlk or ECS.IsSod) | |
| return ECS.IsClassic and (not ECS.IsSoD) |
| textColor = colors.ATTACK_SPEED_SECONDARY, | ||
| statColor = colors.ATTACK_SPEED_PRIMARY, | ||
| }, | ||
| expertise = {display = true, isTbcOnly = true, refName = "Expertise", text = "Expertise"}, |
Owner
There was a problem hiding this comment.
This needs a migration to remove that field for existing profiles.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#343 #166