remove isTbcOnly from profile #394
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
not tested yet, am I going into the right direction? |
add draenei passive to ranged hit calculation
add vscode folder to gitignore
fix annotations
replace deprecated functions
Owner
|
@Alessandro-Barbieri you change a lot of stats to be visible across various expansions. Is that intended? Examples are Armor Pen (visible in every expansion with this PR) and Haste (visible in TBC and WotLK). |
Contributor
Author
it's intentional:
|
BreakBB
reviewed
Jan 26, 2026
| end | ||
| if profileVersion < 23 then | ||
| Profile:Reset() | ||
| ECS:Print(i18n("Profile has been reset due to a major update.")) -- because of TBC prepatch |
Owner
There was a problem hiding this comment.
Suggested change
| ECS:Print(i18n("Profile has been reset due to a major update.")) -- because of TBC prepatch | |
| ECS:Print(i18n("Profile has been reset due to a major update.")) -- because of TBC prepatch |
| category.expertiseRating, category.hasteRating, category.hasteBonus) | ||
| else | ||
| if ECS.IsClassic then | ||
| _CreateStatInfo(category, category.attackPower, category.crit) |
Owner
There was a problem hiding this comment.
Since more values should be shown now, this needs to actually render them. A reminder IsClassic means Era, HC and SoD.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removed
isTbcOnlyswapped the logic on many expansion checks