Do not duplicate autoloaded candidates across multiple CVRs#987
Merged
Do not duplicate autoloaded candidates across multiple CVRs#987
Conversation
artoonie
force-pushed
the
feature/issue-986_autoload-duplicates
branch
from
dbf45b7 to
ef342fb
Compare
yezr
reviewed
Mar 10, 2026
Collaborator
Author
|
TODO: Add tests, preferably using multiple CVR types with the same data |
This was referenced Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #986
We were creating a hashset to prevent duplicate candidates, but that hashset was hashing Candidate objects. Implement .hashCode and .equals to prevent duplicates across multiple CVRs.